CC the maintainers which I missed in the email on this originally. > -----Original Message----- > From: Jeff Brasen <jbra...@nvidia.com> > Sent: Monday, December 11, 2023 9:53 AM > To: Pedro Falcato <pedro.falc...@gmail.com>; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard > functions > > Hit send before adding the cc on this one. (Would probably be good to get > that added to here > (https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > Development-Process) so copy paste doesn't get folks 😊. > > I sent them as different patch series as I thought this one might cause some > discussion and wanted to separate it from that. > > This issue I was seeing is if you both include FdtLib and BaseCryptLib they > both contain implementations of these standard functions with other > functions in the same c files. This results in a link error as the linker > won't > discard part of a compilation unit if it is used so if you have > > Foo.c has functions func1 and func2 > Bar.c has functions func3 and func2 > > If func3 and func1 are both used externally that will cause both objects to be > included and the linker to complain that func2 is defined twice. > > We could move these to c files with just 1 function each in both libraries but > that seemed like a bigger change than this. > > -Jeff > > > > -----Original Message----- > > From: Pedro Falcato <pedro.falc...@gmail.com> > > Sent: Monday, December 11, 2023 9:00 AM > > To: devel@edk2.groups.io; Jeff Brasen <jbra...@nvidia.com> > > Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard > > functions > > > > External email: Use caution opening links or attachments > > > > > > On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io > > <jbrasen=nvidia....@groups.io> wrote: > > > > > > > Jeff, > > > > You're missing CC's on this patch. Also, you should probably send the > > 3 patches in a single series, since they're all related. > > > > > Rename the standard functions in the LibFdtSupport to remove > > > conflicts with other libraries that define them. > > > > This is a funny problem. What error were you seeing? As far as I can > > tell, you can totally define your local C library functions, it > > shouldn't result in any linker errors (even if, IIRC, deemed UB by the C > spec). > > > > -- > > Pedro
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114223): https://edk2.groups.io/g/devel/message/114223 Mute This Topic: https://groups.io/mt/103110792/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
