On Tue, Jan 23, 2024 at 03:16:32PM +0000, Guo, Gua wrote: > For MdeModulePkg, I think no need to change because no any logic change. > > For StandaloneMmPkg and EmbeddedPkg > - Don't have enough abilities to close Sami Mujawar and Ni Ray open > currently, so hold on the change until I find how to introduce Panic. So give > up these two packages patch currently.
On StandaloneMmPkg: I think the patch is fine, I've replied in that subthread. On EmbeddedPkg: I think the BuildGuidDataHob() callsites need review whenever they do: (a) check the return value properly, or (b) allocate a fixed size HOB so the new check in CreateHob() can't fail. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114284): https://edk2.groups.io/g/devel/message/114284 Mute This Topic: https://groups.io/mt/103675959/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-