Hello Sami,
On 1/25/24 12:31, Sami Mujawar wrote:
Hi Pierre,
Thank you for this patch.
I just have a minor suggestion marked inline as [SAMI].
Otherwise, this patch looks good to me.
With that addressed,
Reviewed-by: Sami Mujawar <[email protected]>
Regards,
Sami Mujawar
On 12/12/2023, 09:31, "[email protected] <mailto:[email protected]>"
<[email protected] <mailto:[email protected]>> wrote:
From: Pierre Gondois <[email protected] <mailto:[email protected]>>
The SsdtCpuTopologyGenerator can generate _PSD objects.
Add _PSD information and handling to the Configuration Manager
to generate them.
Signed-off-by: Pierre Gondois <[email protected]
<mailto:[email protected]>>
---
.../ConfigurationManager.c | 98 +++++++++++++++++--
.../ConfigurationManager.h | 24 ++++-
2 files changed, 113 insertions(+), 9 deletions(-)
[snip]
@@ -283,6 +300,9 @@ typedef struct PlatformRepositoryInfo {
// Cores Low Power Idle state references (LPI)
CM_ARM_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT];
+ // Power domains
[SAMI] The comment could also say that this information is dynamically
populated by the configuration manager.
I think the _PSD info is statically defined, only the _CPC information
is dynamically populated.
+ CM_ARM_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT];
+
/// Juno Board Revision
UINT32 JunoRevision;
} EDKII_PLATFORM_REPOSITORY_INFO;
--
2.25.1
Regards,
Pierre
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114400): https://edk2.groups.io/g/devel/message/114400
Mute This Topic: https://groups.io/mt/103127067/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
