REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694
If no Cc tags are detected in a commit message, then generate an error. All patches sent for review are required to provide the set of maintainers and reviewers responsible for the directories/files modified. The set of maintainers and reviewers are documented in Maintainers.txt and can be retrieved using the script BaseTools/Scripts/GetMaintainer.py. Cc: Rebecca Cran <[email protected]> Cc: Liming Gao <[email protected]> Cc: Bob Feng <[email protected]> Cc: Yuwei Chen <[email protected]> Cc: Michael Kubacki <[email protected]> Signed-off-by: Michael D Kinney <[email protected]> --- BaseTools/Scripts/PatchCheck.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 158a2b30a5ce..415198e3824e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -229,8 +229,10 @@ class CommitMessageCheck: ) def check_misc_signatures(self): - for sig in self.sig_types: - self.find_signatures(sig) + for sigtype in self.sig_types: + sigs = self.find_signatures(sigtype) + if sigtype == 'Cc' and len(sigs) == 0: + self.error('No Cc: tags for maintainers/reviewers found!') cve_re = re.compile('CVE-[0-9]{4}-[0-9]{5}[^0-9]') -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115571): https://edk2.groups.io/g/devel/message/115571 Mute This Topic: https://groups.io/mt/104434584/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
