[AMD Official Use Only - General] > -----Original Message----- > From: Nickle Wang <nick...@nvidia.com> > Sent: Tuesday, February 20, 2024 2:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner <abner.ch...@amd.com>; Igor Kulchytskyy > <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external > symbol issue > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > -Fix below compiler error reported in edk2 CI. > ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external > symbol __ftol2 > -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. > -Add MathFtol.c to EccCheck IgnoreFiles. > > Signed-off-by: Nickle Wang <nick...@nvidia.com> > Cc: Abner Chang <abner.ch...@amd.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > Cc: Nick Ramirez <nrami...@nvidia.com> > --- > .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++- > .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++ > RedfishPkg/RedfishPkg.ci.yaml | 2 + > 3 files changed, 45 insertions(+), 1 deletion(-) > create mode 100644 > RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > index 6ff5dba75c..3a5e309d1a 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > @@ -3,6 +3,7 @@ > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > # (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -23,6 +24,9 @@ > [Sources] > RedfishCrtLib.c > > +[Sources.IA32] > + Ia32/MathFtol.c | MSFT > + > [LibraryClasses] > BaseLib > SortLib > @@ -35,4 +39,5 @@ > MdeModulePkg/MdeModulePkg.dec > RedfishPkg/RedfishPkg.dec > > - > +[BuildOptions] > + MSFT:*_*_IA32_CC_FLAGS = /GL- > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > new file mode 100644 > index 0000000000..adfe249b1d > --- /dev/null > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > @@ -0,0 +1,37 @@ > +/** @file
Hi Nickle, Could you please add the information here after @file about where this file or the source code come from, such as the location of original file? Thanks Abner > + 64-bit Math Worker Function. > + The 32-bit versions of C compiler generate calls to library routines > + to handle 64-bit math. These functions use non-standard calling > conventions. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +/* > + * Floating point to integer conversion. > + */ > +__declspec(naked) void > +_ftol2 ( > + void > + ) > +{ > + _asm { > + fistp qword ptr [esp-8] > + mov edx, [esp-4] > + mov eax, [esp-8] > + ret > + } > +} > + > +__declspec(naked) void > +_ftol2_sse ( > + void > + ) > +{ > + _asm { > + fistp dword ptr [esp-4] > + mov eax,[esp-4] > + ret > + } > +} > diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml > index 69b6bf39f5..b95e8bfdc7 100644 > --- a/RedfishPkg/RedfishPkg.ci.yaml > +++ b/RedfishPkg/RedfishPkg.ci.yaml > @@ -2,6 +2,7 @@ > # CI configuration for NetworkPkg > # > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > { > @@ -38,6 +39,7 @@ > "PrivateInclude/Crt/string.h", > "PrivateInclude/Crt/time.h", > "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c", > + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c", > "Include/Library/RedfishCrtLib.h", > ## > ## For jansson library open source > -- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115696): https://edk2.groups.io/g/devel/message/115696 Mute This Topic: https://groups.io/mt/104463409/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-