On 2/21/24 04:35, Ni, Ray wrote: >> -----Original Message----- >> From: Gerd Hoffmann <kra...@redhat.com> >> Sent: Wednesday, February 21, 2024 1:50 AM >> To: devel@edk2.groups.io >> Cc: Oliver Steffen <ostef...@redhat.com>; Laszlo Ersek >> <ler...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Ni, Ray >> <ray...@intel.com>; Gerd Hoffmann <kra...@redhat.com> >> Subject: [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add support for multiple >> HOBs to GetMpHandOffHob >> >> Rename the function to GetNextMpHandOffHob(), add MP_HAND_OFF >> parameter. >> When called with NULL pointer return the first HOB, otherwise return the >> next in the chain. >> >> Also add the function prototype to the MpLib.h header file. >> >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> >> --- >> UefiCpuPkg/Library/MpInitLib/MpLib.h | 12 ++++++++++++ >> UefiCpuPkg/Library/MpInitLib/MpLib.c | 26 ++++++++++++++++---------- >> 2 files changed, 28 insertions(+), 10 deletions(-) >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h >> b/UefiCpuPkg/Library/MpInitLib/MpLib.h >> index a96a6389c17d..bc2a0232291d 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h >> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h >> @@ -485,6 +485,18 @@ SwitchApContext ( >> IN MP_HAND_OFF *MpHandOff >> ); >> >> +/** >> + Get pointer to next MP_HAND_OFF GUIDed HOB. >> + >> + @param[in] MpHandOff Previous HOB. Pass NULL to get the first >> HOB. > > Can you please emphasize in above comments that MpHandOff points to the > GUIDed HOB data? > The function implementation assumes that.
+1; had the same observation. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115761): https://edk2.groups.io/g/devel/message/115761 Mute This Topic: https://groups.io/mt/104472308/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
