I agree this change. It should have no negative impact. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Michael: Have you any comments for this change? Thanks Liming > -----邮件原件----- > 发件人: Zhihao Li <zhihao...@intel.com> > 发送时间: 2024年3月1日 15:12 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao <gaolim...@byosoft.com.cn> > 主题: [PATCH v1] MdeModulePkg/Core/Pei: Improve the copy performance > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4697 > > EvacuateTempRam function will copy the temporary memory context to the > rebased > pages and the raw pages. Migrations of rebased PEIMs is from cache to > memory, > while raw PEIMs is from memory to memory. So the migrations of raw PEIMs > is slower than rebased PEIMs. Experimental data indicates that changing the > source > address of raw PEIMs migration will improve performance by 35%. > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Signed-off-by: Zhihao Li <zhihao...@intel.com> > --- > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c > b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c > index 4cd8c843cd..ca37bde482 100644 > --- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c > +++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c > @@ -1,7 +1,7 @@ > /** @file > EFI PEI Core dispatch services > > -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.<BR> > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -1305,7 +1305,7 @@ EvacuateTempRam ( > ); > ASSERT_EFI_ERROR (Status); > RawDataFvHeader = (EFI_FIRMWARE_VOLUME_HEADER > *)(UINTN)FvHeaderAddress; > - CopyMem (RawDataFvHeader, MigratedFvHeader, > (UINTN)FvHeader->FvLength); > + CopyMem (RawDataFvHeader, FvHeader, > (UINTN)FvHeader->FvLength); > MigratedFvInfo.FvDataBase = > (UINT32)(UINTN)RawDataFvHeader; > } > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116249): https://edk2.groups.io/g/devel/message/116249 Mute This Topic: https://groups.io/mt/104662794/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
