Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo > Ersek > Sent: Wednesday, March 6, 2024 1:10 PM > To: edk2-devel-groups-io <devel@edk2.groups.io> > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Chaganty, > Rangasai V <rangasai.v.chaga...@intel.com> > Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 2/4] > SimicsOpenBoardPkg: auto-gen & fix SEC ProcessLibraryConstructorList() > decl > > Can I please get a quick R-b for this patch -- it's urgent because of > <https://edk2.groups.io/g/devel/message/116453>. > > Thank you, > Laszlo > > On 3/5/24 13:01, Laszlo Ersek wrote: > > <Library/PeimEntryPoint.h> declares a bogus > > ProcessLibraryConstructorList() for SimicsOpenBoardPkg's SEC module. > Rely > > on AutoGen for (properly) declaring ProcessLibraryConstructorList(). > > Update the call. > > > > Build-tested with: > > > > - appending the following directories to PACKAGES_PATH: > > > > Drivers > > Features/Intel > > Features/Intel/Debugging > > Features/Intel/Network > > Features/Intel/OutOfBandManagement > > Features/Intel/PowerManagement > > Features/Intel/SystemInformation > > Features/Intel/UserInterface > > Platform/Intel > > Silicon/Intel > > > > - commenting out "SimicsIch10BinPkg/UndiBinary/UndiDxe.inf" in > > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc" > and > > "Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf" > > > > - running the command > > > > build -a IA32 -a X64 -b DEBUG \ > > -m Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf \ > > -p > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc \ > > -t GCC5 > > > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > --- > > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 2 +- > > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +-- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > > index af1c0f2b55d1..fcf34c0def4e 100644 > > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > > @@ -8,7 +8,7 @@ > > ## > > > > [Defines] > > - INF_VERSION = 0x00010005 > > + INF_VERSION = 1.30 > > BASE_NAME = SecMain > > FILE_GUID = e67f156f-54c5-47f3-a35d- > 07c045881e14 > > MODULE_TYPE = SEC > > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > > index 39e879e9223e..09d43c6bf63b 100644 > > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > > @@ -9,7 +9,6 @@ > > > > #include <PiPei.h> > > > > -#include <Library/PeimEntryPoint.h> > > #include <Library/BaseLib.h> > > #include <Library/DebugLib.h> > > #include <Library/BaseMemoryLib.h> > > @@ -738,7 +737,7 @@ SecCoreStartupWithStack ( > > Table[Index] = 0; > > } > > > > - ProcessLibraryConstructorList (NULL, NULL); > > + ProcessLibraryConstructorList (); > > > > DEBUG ((EFI_D_INFO, > > "SecCoreStartupWithStack(0x%x, 0x%x)\n", > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116463): https://edk2.groups.io/g/devel/message/116463 Mute This Topic: https://groups.io/mt/104742758/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
