Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, March 6, 2024 1:10 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Andrew Fish <af...@apple.com>; Ni, Ray <ray...@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 07/10] EmulatorPkg: auto-generate
> SEC ProcessLibraryConstructorList() decl
> 
> Can I please get a quick R-b for this patch -- it's urgent because of
> <https://edk2.groups.io/g/devel/message/116453>.
> 
> Thank you,
> Laszlo
> 
> On 3/5/24 12:38, Laszlo Ersek wrote:
> > Rely on AutoGen for declaring ProcessLibraryConstructorList().
> >
> > Build-tested with:
> >
> >   build -a X64 -b DEBUG -m EmulatorPkg/Sec/Sec.inf \
> >     -p EmulatorPkg/EmulatorPkg.dsc -t GCC5
> >
> > Cc: Andrew Fish <af...@apple.com>
> > Cc: Ray Ni <ray...@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> > Signed-off-by: Laszlo Ersek <ler...@redhat.com>
> > ---
> >  EmulatorPkg/Sec/Sec.inf | 2 +-
> >  EmulatorPkg/Sec/Sec.h   | 9 ---------
> >  2 files changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/EmulatorPkg/Sec/Sec.inf b/EmulatorPkg/Sec/Sec.inf
> > index 2f9e3d4780cc..7476094f1305 100644
> > --- a/EmulatorPkg/Sec/Sec.inf
> > +++ b/EmulatorPkg/Sec/Sec.inf
> > @@ -11,7 +11,7 @@
> >  ##
> >
> >  [Defines]
> > -  INF_VERSION                    = 0x00010005
> > +  INF_VERSION                    = 1.30
> >    BASE_NAME                      = EmuSec
> >    FILE_GUID                      = BCAF98C9-22B0-3B4F-9CBD-
> C8A6B4DBCEE9
> >    MODULE_TYPE                    = SEC
> > diff --git a/EmulatorPkg/Sec/Sec.h b/EmulatorPkg/Sec/Sec.h
> > index 29272a29ffa5..94689eb41d35 100644
> > --- a/EmulatorPkg/Sec/Sec.h
> > +++ b/EmulatorPkg/Sec/Sec.h
> > @@ -20,15 +20,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  #include <Ppi/TemporaryRamSupport.h>
> >
> > -//
> > -// I think this should be defined in a MdePkg include file?
> > -//
> > -VOID
> > -EFIAPI
> > -ProcessLibraryConstructorList (
> > -  VOID
> > -  );
> > -
> >  EFI_STATUS
> >  EFIAPI
> >  SecTemporaryRamSupport (
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116464): https://edk2.groups.io/g/devel/message/116464
Mute This Topic: https://groups.io/mt/104742527/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to