[AMD Official Use Only - General] Hi Igor, If time is allowed, please also review this patch set. Thanks Abner
> -----Original Message----- > From: Nickle Wang <nick...@nvidia.com> > Sent: Wednesday, March 27, 2024 3:42 PM > To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io > Cc: Igor Kulchytskyy <ig...@ami.com> > Subject: RE: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching > algorithm enhancement and the bug fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > I have tested this patch series on my system and got a lot of performance > improvements too. > > Great work, Abner! > > Regards, > Nickle > > > -----Original Message----- > > From: abner.ch...@amd.com <abner.ch...@amd.com> > > Sent: Tuesday, March 26, 2024 11:15 PM > > To: devel@edk2.groups.io > > Cc: Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com> > > Subject: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching > algorithm > > enhancement and the bug fixes > > > > External email: Use caution opening links or attachments > > > > > > From: Abner Chang <abner.ch...@amd.com> > > > > PR # 5491 > > > > In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path > > implementation based on the performance improvement. > > > > In this patch set, > > 1 We enhance the config language searching algorithm. > > As the performance of searching config language using HII GetString is > > pretty slow. For the example, 1800 HII BIOS options takes over 30 mins > > to build up the metadata required for Redfish BIOS resource. With this > > improvement, it only takes 4 seconds. > > > > 2.Introduce the Redfish debug framework, there are three edk2 Redfish > > debug scopes. > > a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug > message > > for edk2 Redfish. > > b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish > > component. Currently we only support RedfishPlatformConfigDxe > > module. > > c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug > > scope. This PCD is used by RedfishPlatformConfigDxe debug enablement. > > > > 3 This patch set also fixes an issue that deletes HII string unexpectedly. > > > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > > Co-authored-by: Nickle Wang <nick...@nvidia.com> > > Cc: Igor Kulchytskyy <ig...@ami.com> > > > > Abner Chang (4): > > RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro > > RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support > > RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted > > unexpectedly > > EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs > > > > Nickle Wang (1): > > RedfishPkg/RedfishPlatformConfigDxe: support menu path report > > > > abnchang (1): > > RedfishPkg/RedfishPlatformConfigDxe: Config language searching > > optimization > > > > RedfishPkg/RedfishPkg.dec | 24 + > > EmulatorPkg/EmulatorPkg.dsc | 21 + > > .../RedfishDebugLib/RedfishDebugLib.inf | 4 + > > .../RedfishPlatformConfigDxe.inf | 8 + > > RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +- > > .../RedfishPlatformConfigDxe.h | 48 +- > > .../RedfishPlatformConfigImpl.h | 135 ++- > > .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +- > > .../RedfishPlatformConfigCapability.c | 58 ++ > > .../RedfishPlatformConfigDxe.c | 89 +- > > .../RedfishPlatformConfigImpl.c | 928 ++++++++++++++++-- > > 11 files changed, 1240 insertions(+), 173 deletions(-) create mode 100644 > > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c > > > > -- > > 2.37.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117158): https://edk2.groups.io/g/devel/message/117158 Mute This Topic: https://groups.io/mt/105159781/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
