merged.
Thanks,
Ray
________________________________
From: Shang, Qingyu <qingyu.sh...@intel.com>
Sent: Monday, April 8, 2024 17:47
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Pedro Falcato <pedro.falc...@gmail.com>; Ni, Ray <ray...@intel.com>; Gahan
Saraiya <gahan.sara...@intel.com>
Subject: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
Refer to Uefi spec 2.10 section 11.11.2, add a new retval
EFI_NOT_FOUND to EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation().
Reference: [mantis #1866] - GetInfo() of Adapter Information
Protocol should have a provision for IHV to return no data.
Cc: Pedro Falcato <pedro.falc...@gmail.com>
Cc: Ray Ni <ray...@intel.com>
Signed-off-by: Qingyu <qingyu.sh...@intel.com>
Signed-off-by: Gahan Saraiya <gahan.sara...@intel.com>
---
Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h | 5 ++++-
Drivers/OptionRomPkg/UndiRuntimeDxe/UndiAipImpl.c | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
b/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
index 31c55a8e11..665221e952 100644
--- a/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
+++ b/Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
@@ -350,7 +350,9 @@ VOID PxeUpdate (NIC_DATA_INSTANCE *NicPtr, PXE_SW_UNDI
*PxePtr);
This function returns information of type InformationType from the adapter.
If an adapter does not support the requested informational type, then
- EFI_UNSUPPORTED is returned.
+ EFI_UNSUPPORTED is returned. If an adapter does not contain Information for
+ the requested InformationType, it fills InformationBlockSize with 0 and
+ returns EFI_NOT_FOUND.
@param[in] This A pointer to the
EFI_ADAPTER_INFORMATION_PROTOCOL instance.
@param[in] InformationType A pointer to an EFI_GUID that defines the
contents of InformationBlock.
@@ -360,6 +362,7 @@ VOID PxeUpdate (NIC_DATA_INSTANCE *NicPtr, PXE_SW_UNDI
*PxePtr);
@retval EFI_SUCCESS The InformationType information was
retrieved.
@retval EFI_UNSUPPORTED The InformationType is not known.
+ @retval EFI_NOT_FOUND Information is not available for the
requested information type.
@retval EFI_DEVICE_ERROR The device reported an error.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to
a lack of resources.
@retval EFI_INVALID_PARAMETER This is NULL.
diff --git a/Drivers/OptionRomPkg/UndiRuntimeDxe/UndiAipImpl.c
b/Drivers/OptionRomPkg/UndiRuntimeDxe/UndiAipImpl.c
index 21151a076f..d80ce65da9 100644
--- a/Drivers/OptionRomPkg/UndiRuntimeDxe/UndiAipImpl.c
+++ b/Drivers/OptionRomPkg/UndiRuntimeDxe/UndiAipImpl.c
@@ -18,7 +18,9 @@ EFI_GUID mSupportedInfoTypes[] = {
This function returns information of type InformationType from the adapter.
If an adapter does not support the requested informational type, then
- EFI_UNSUPPORTED is returned.
+ EFI_UNSUPPORTED is returned. If an adapter does not contain Information for
+ the requested InformationType, it fills InformationBlockSize with 0 and
+ returns EFI_NOT_FOUND.
@param[in] This A pointer to the
EFI_ADAPTER_INFORMATION_PROTOCOL instance.
@param[in] InformationType A pointer to an EFI_GUID that defines the
contents of InformationBlock.
@@ -28,6 +30,7 @@ EFI_GUID mSupportedInfoTypes[] = {
@retval EFI_SUCCESS The InformationType information was
retrieved.
@retval EFI_UNSUPPORTED The InformationType is not known.
+ @retval EFI_NOT_FOUND Information is not available for the
requested information type.
@retval EFI_DEVICE_ERROR The device reported an error.
@retval EFI_OUT_OF_RESOURCES The request could not be completed due to
a lack of resources.
@retval EFI_INVALID_PARAMETER This is NULL.
--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117565): https://edk2.groups.io/g/devel/message/117565
Mute This Topic: https://groups.io/mt/105398061/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
