Thanks Gerd, I will try the S3 on OVMF. And for AmdSmmRelocationLib usage in OVMF, do you prefer: 1. use the AmdSmmRelocationLib directly in this patch set? Or 2. still keep the original to create the OvmfPkg/SmmRelocationLib, and clean the code in the future patch?
Both are fine to me, depends on you. Thanks, Jiaxin > -----Original Message----- > From: Gerd Hoffmann <[email protected]> > Sent: Monday, April 22, 2024 3:58 PM > To: Wu, Jiaxin <[email protected]> > Cc: [email protected]; Ni, Ray <[email protected]>; Zeng, Star > <[email protected]>; Kumar, Rahul R <[email protected]>; Dong, > Guo <[email protected]>; Rhodes, Sean <[email protected]>; Lu, > James <[email protected]>; Guo, Gua <[email protected]>; Ard Biesheuvel > <[email protected]>; Yao, Jiewen <[email protected]>; Abdul > Lateef Attar <[email protected]>; Abner Chang > <[email protected]>; Tom Lendacky <[email protected]> > Subject: Re: [edk2-devel] [PATCH v3 00/13] Add SmmRelocationLib > > On Thu, Apr 18, 2024 at 08:02:43AM +0000, Wu, Jiaxin wrote: > > Hi Gerd, > > > > Could you help review & check below OVMF related patches? > > > > > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > > > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > > > OvmfPkg: Refine SmmAccess implementation > > > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > > > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > Patch series breaks S3 suspend support in OVMF. > > On a quick check (OvmfPkgX64 only) using AmdSmmRelocationLib.inf for > OVMF seems to work fine (S3 is broken too though). > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118128): https://edk2.groups.io/g/devel/message/118128 Mute This Topic: https://groups.io/mt/105593568/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
