Thanks Ray, please help add the push label for the PR: https://github.com/tianocore/edk2/pull/5610
From: Ni, Ray <ray...@intel.com> Sent: Tuesday, April 30, 2024 1:33 PM To: Wu, Jiaxin <jiaxin...@intel.com>; devel@edk2.groups.io Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com> Subject: Re: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport Reviewed-by: Ray Ni <ray...@intel.com<mailto:ray...@intel.com>> Thanks, Ray ________________________________ From: Wu, Jiaxin <jiaxin...@intel.com<mailto:jiaxin...@intel.com>> Sent: Monday, April 29, 2024 13:31 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Ni, Ray <ray...@intel.com<mailto:ray...@intel.com>>; Zeng, Star <star.z...@intel.com<mailto:star.z...@intel.com>>; Gerd Hoffmann <kra...@redhat.com<mailto:kra...@redhat.com>>; Kumar, Rahul R <rahul.r.ku...@intel.com<mailto:rahul.r.ku...@intel.com>> Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport ProcessorNumber 0 is not always BSP. Debug message based on 0 of ProcessorNumber is incorrect. This patch is to clean the debug message in LmceSupport directly. Cc: Ray Ni <ray...@intel.com<mailto:ray...@intel.com>> Cc: Zeng Star <star.z...@intel.com<mailto:star.z...@intel.com>> Cc: Gerd Hoffmann <kra...@redhat.com<mailto:kra...@redhat.com>> Cc: Rahul Kumar <rahul1.ku...@intel.com<mailto:rahul1.ku...@intel.com>> Signed-off-by: Jiaxin Wu <jiaxin...@intel.com<mailto:jiaxin...@intel.com>> --- UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c index d8b070d9f1..cb569769a1 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c @@ -1,9 +1,9 @@ /** @file Machine Check features. - Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ #include "CpuCommonFeatures.h" @@ -287,13 +287,10 @@ LmceSupport ( if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) { return FALSE; } McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP); - if (ProcessorNumber == 0) { - DEBUG ((DEBUG_INFO, "LMCE enable = %x\n", (BOOLEAN)(McgCap.Bits.MCG_LMCE_P != 0))); - } return (BOOLEAN)(McgCap.Bits.MCG_LMCE_P != 0); } /** -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118410): https://edk2.groups.io/g/devel/message/118410 Mute This Topic: https://groups.io/mt/105795776/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
