I had not passed some tests, apologies. I fixed the spacing issue and
build failure with too many )s in
https://github.com/tianocore/edk2/pull/5615. Shall I email a v4?

On Sun, May 5, 2024 at 8:28 PM Yao, Jiewen <[email protected]> wrote:
>
> Hi Dionna
> I tried to create PR but I saw failure - 
> https://github.com/tianocore/edk2/pull/5628
>
> Would you please clarify if you have tested the patch in EDKII CI, before you 
> submit the patch?
>
>
> BTW: I have fixed a typo in the V3 patch. The "Reviewed-By" tag in 1/3 should 
> be "Reviewed-by".
>
> Thank you
> Yao, Jiewen
>
>
>
> > -----Original Message-----
> > From: Dionna Glaze <[email protected]>
> > Sent: Thursday, May 2, 2024 8:50 AM
> > To: [email protected]
> > Cc: Dionna Glaze <[email protected]>; Kinney, Michael D
> > <[email protected]>; Liming Gao <[email protected]>; Liu,
> > Zhiguang <[email protected]>; Yao, Jiewen <[email protected]>;
> > Kumar, Rahul R <[email protected]>; Ard Biesheuvel
> > <[email protected]>; Gerd Hoffmann <[email protected]>
> > Subject: [PATCH v3 0/3] TCG_Sp800_155_PlatformId_Event3 support
> >
> > In December 2023, the TCG published the PC Client Platform Firmware
> > Profile version 1.06 revision 52. This revision includes a new event
> > type for NIST SP 800-155 recommended signed BIOS reference measurements.
> > The new type allows for the event log auditor to find local or remote
> > copies of the signed reference measurements.
> >
> > Supporting this new event type eases the process of distributing signed
> > reference measurements since the machine can now simply report where
> > they can be found in a standard way.
> >
> > Changes since v2:
> >   - Removed errant spacing.
> > Changes since v1:
> >   - MdePkg defines TCG_Sp800_155_PlatformId_Event3 instead of adding a
> >     comment about Event3 to Event2.
> >
> > Cc: Michael D Kinney <[email protected]>
> > Cc: Liming Gao <[email protected]>
> > Cc: Zhiguang Liu <[email protected]>
> > Cc: Jiewen Yao <[email protected]>
> > Cc: Rahul Kumar <[email protected]>
> > Cc: Ard Biesheuvel <[email protected]>
> > Cc: Gerd Hoffmann <[email protected]>
> > Reviewed-by: Jiewen Yao <[email protected]>
> >
> > Dionna Glaze (3):
> >   MdePkg: Add TcgSp800155Event3 type info
> >   SecurityPkg: recognize sp800155Event3 event too
> >   OvmfPkg: add sp800155Event3 support
> >
> >  .../IndustryStandard/UefiTcgPlatform.h        | 38 ++++++++++++++++++-
> >  OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c             |  9 ++++-
> >  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c             |  9 ++++-
> >  3 files changed, 51 insertions(+), 5 deletions(-)
> >
> > --
> > 2.45.0.rc0.197.gbae5840b3b-goog



-- 
-Dionna Glaze, PhD, CISSP (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118609): https://edk2.groups.io/g/devel/message/118609
Mute This Topic: https://groups.io/mt/105854725/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to