Sami: Thanks for your update. I agree Pierre reviewed this patch before the soft feature freeze. So, this patch can be merged for this stable tag 202405.
Thanks Liming 发件人: [email protected] <[email protected]> 代表 Sami Mujawar 发送时间: 2024年5月9日 18:18 收件人: [email protected]; [email protected]; 'Attar, AbdulLateef (Abdul Lateef)' <[email protected]> 抄送: Pierre Gondois <[email protected]>; 'Leif Lindholm' <[email protected]>; 'Andrew Fish' <[email protected]>; 'Michael Kinney' <[email protected]> 主题: Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Hi Liming, > What’s your comments for this patch? The patch was reviewed by Pierre at https://edk2.groups.io/g/devel/message/118589 before the feature freeze email was sent out. Pierre had some minor recommendations that Abdul has addressed in the V2 patch. Ideally Pierre’s the r-b tag could have been carried forward. > Is this a required bug fix or new feature? This is adding a new feature by introducing a new API, and I think it should not impact the existing functionality as such. So, by merging this patch the risk of breaking existing functionality seems to be low. This patch looks good to me. Reviewed-by: Sami Mujawar <[email protected] <mailto:[email protected]> > Regards, Sami Mujawar From: <[email protected] <mailto:[email protected]> > on behalf of "gaoliming via groups.io" <[email protected] <mailto:[email protected]> > Reply to: "[email protected] <mailto:[email protected]> " <[email protected] <mailto:[email protected]> >, "[email protected] <mailto:[email protected]> " <[email protected] <mailto:[email protected]> > Date: Thursday 9 May 2024 at 10:01 To: "'Attar, AbdulLateef (Abdul Lateef)'" <[email protected] <mailto:[email protected]> >, "[email protected] <mailto:[email protected]> " <[email protected] <mailto:[email protected]> > Cc: Pierre Gondois <[email protected] <mailto:[email protected]> >, Sami Mujawar <[email protected] <mailto:[email protected]> >, 'Leif Lindholm' <[email protected] <mailto:[email protected]> >, 'Andrew Fish' <[email protected] <mailto:[email protected]> >, 'Michael Kinney' <[email protected] <mailto:[email protected]> > Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Resent from: <[email protected] <mailto:[email protected]> > Resent date: Thursday 9 May 2024 at 10:00 Sami and Pierre: What’s your comments for this patch? Is this a required bug fix or new feature? Thanks Liming 发件人: Attar, AbdulLateef (Abdul Lateef) <[email protected] <mailto:[email protected]> > 发送时间: 2024年5月9日 16:39 收件人: gaoliming <[email protected] <mailto:[email protected]> >; [email protected] <mailto:[email protected]> 抄送: 'Pierre Gondois' <[email protected] <mailto:[email protected]> >; 'Sami Mujawar' <[email protected] <mailto:[email protected]> > 主题: Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node [AMD Official Use Only - General] Hi Liming, This patch provides an API to add integer value to AML package node. Using this API user can create CXL device with two PNPID. Without this API user has to rely on static ASL files. This patch is required for platform who uses DynamicTablesPkg to generate ACPI tables based on this stable release. Thanks AbduL _____ From: gaoliming <[email protected] <mailto:[email protected]> > Sent: Thursday, May 9, 2024 1:10 PM To: [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]> >; Attar, AbdulLateef (Abdul Lateef) <[email protected] <mailto:[email protected]> > Cc: 'Pierre Gondois' <[email protected] <mailto:[email protected]> >; 'Sami Mujawar' <[email protected] <mailto:[email protected]> > Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abdul: Can you give more information why this change is required for this stable tag 202405? Thanks Liming > -----邮件原件----- > 发件人: [email protected] <mailto:[email protected]> > <[email protected] <mailto:[email protected]> > 代表 Abdul Lateef > Attar via groups.io > 发送时间: 2024年5月9日 12:49 > 收件人: [email protected] <mailto:[email protected]> > 抄送: Abdul Lateef Attar <[email protected] > <mailto:[email protected]> >; Pierre Gondois > <[email protected] <mailto:[email protected]> >; Sami Mujawar > <[email protected] <mailto:[email protected]> > > 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] > DynamicTablesPkg: Adds integer to the AML package node > > Adds an AmlAddIntegerToNamedPackage() API to generate AML code, > which adds an integer value to the package node. > > Cc: Pierre Gondois <[email protected] <mailto:[email protected]> > > Cc: Sami Mujawar <[email protected] <mailto:[email protected]> > > Signed-off-by: Abdul Lateef Attar <[email protected] > <mailto:[email protected]> > > --- > .../Include/Library/AmlLib/AmlLib.h | 41 +++++++++++- > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 67 > +++++++++++++++++++ > 2 files changed, 107 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > index 82d5464084..4427ab68fa 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -2,7 +2,7 @@ > AML Lib. > > Copyright (c) 2019 - 2023, Arm Limited. All rights reserved.<BR> > - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR> > + Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights > reserved.<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -1743,6 +1743,45 @@ AmlAddNameStringToNamedPackage ( > IN AML_OBJECT_NODE_HANDLE NamedNode > ); > > +/** Add an integer value to the named package node. > + > + AmlCodeGenNamePackage ("_CID", NULL, &PackageNode); > + AmlGetEisaIdFromString ("PNP0A03", &EisaId); > + AmlAddIntegerToNamedPackage (EisaId, NameNode); > + AmlGetEisaIdFromString ("PNP0A08", &EisaId); > + AmlAddIntegerToNamedPackage (EisaId, NameNode); > + > + equivalent of the following ASL code: > + Name (_CID, Package (0x02) // _CID: Compatible ID > + { > + EisaId ("PNP0A03"), > + EisaId ("PNP0A08") > + }) > + > + The package is added at the tail of the list of the input package node > + name: > + Name ("NamePackageNode", Package () { > + [Pre-existing package entries], > + [Newly created integer entry] > + }) > + > + > + @ingroup CodeGenApis > + > + @param [in] Integer Integer value that need to be added to > package node. > + @param [in, out] NameNode Package named node to add the object > to. > + > + @retval EFI_SUCCESS Success. > + @retval EFI_INVALID_PARAMETER Invalid parameter. > + @retval Others Error occurred during the operation. > +**/ > +EFI_STATUS > +EFIAPI > +AmlAddIntegerToNamedPackage ( > + IN UINT32 Integer, > + IN OUT AML_OBJECT_NODE_HANDLE NameNode > + ); > + > /** AML code generation to invoke/call another method. > > This method is a subset implementation of MethodInvocation > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index 22c2d598d0..89fa4e06f8 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -3871,6 +3871,73 @@ exit_handler: > return Status; > } > > +/** Add an integer value to the named package node. > + > + AmlCodeGenNamePackage ("_CID", NULL, &PackageNode); > + AmlGetEisaIdFromString ("PNP0A03", &EisaId); > + AmlAddIntegerToNamedPackage (EisaId, NameNode); > + AmlGetEisaIdFromString ("PNP0A08", &EisaId); > + AmlAddIntegerToNamedPackage (EisaId, NameNode); > + > + equivalent of the following ASL code: > + Name (_CID, Package (0x02) // _CID: Compatible ID > + { > + EisaId ("PNP0A03"), > + EisaId ("PNP0A08") > + }) > + > + The package is added at the tail of the list of the input package node > + name: > + Name ("NamePackageNode", Package () { > + [Pre-existing package entries], > + [Newly created integer entry] > + }) > + > + > + @ingroup CodeGenApis > + > + @param [in] Integer Integer value that need to be added to > package node. > + @param [in, out] NameNode Package named node to add the object > to. > + > + @retval EFI_SUCCESS Success. > + @retval EFI_INVALID_PARAMETER Invalid parameter. > + @retval Others Error occurred during the operation. > +**/ > +EFI_STATUS > +EFIAPI > +AmlAddIntegerToNamedPackage ( > + IN UINT32 Integer, > + IN OUT AML_OBJECT_NODE_HANDLE NameNode > + ) > +{ > + EFI_STATUS Status; > + AML_OBJECT_NODE *PackageNode; > + > + if (NameNode == NULL) { > + ASSERT_EFI_ERROR (FALSE); > + return EFI_INVALID_PARAMETER; > + } > + > + PackageNode = (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument ( > + NameNode, > + EAmlParseIndexTerm1 > + ); > + if ((PackageNode == NULL) > || > + (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) != > EAmlNodeObject) || > + (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0))) > + { > + ASSERT_EFI_ERROR (FALSE); > + return EFI_INVALID_PARAMETER; > + } > + > + Status = AmlAddRegisterOrIntegerToPackage (NULL, Integer, PackageNode); > + if (EFI_ERROR (Status)) { > + ASSERT_EFI_ERROR (Status); > + } > + > + return Status; > +} > + > /** AML code generation to invoke/call another method. > > This method is a subset implementation of MethodInvocation > -- > 2.34.1 > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118764): https://edk2.groups.io/g/devel/message/118764 Mute This Topic: https://groups.io/mt/105999922/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
