Hi Liming, Pull request is done and pipelines are built successfully and the patch is ready to push to the master.
Thanks, Praveen Sankar -----Original Message----- From: gaoliming <gaolim...@byosoft.com.cn> Sent: Monday, May 6, 2024 7:53 AM To: Praveen Sankar N <praveensank...@ami.com>; devel@edk2.groups.io Cc: Srinivasan Mani <srinivas...@ami.com>; Sundaresan S <sundares...@ami.com>; michael.d.kin...@intel.com; zhiguang....@intel.com; Felix Polyudov <fel...@ami.com>; Rabisha R <rabis...@ami.com> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: Praveen Sankar N <praveensank...@ami.com> > 发送时间: 2024年5月2日 19:16 > 收件人: devel@edk2.groups.io > 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani <srinivas...@ami.com>; > Sundaresan S <sundares...@ami.com>; michael.d.kin...@intel.com; > zhiguang....@intel.com; Felix Polyudov <fel...@ami.com>; Rabisha R > <rabis...@ami.com> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure > > In SPCR table, 4 structure members have been added newly as per SPCR > table Revision 4, which has to be added in > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h. > > Signed-off-by: Praveen Sankar N praveensank...@ami.com > > Cc: michael.d.kin...@intel.com > > Cc: gaolim...@byosoft.com.cn > > Cc: zhiguang....@intel.com > > Cc: fel...@ami.com > > Cc: srinivas...@ami.com > > Cc: sundares...@ami.com > > Cc: rabis...@ami.com > --- > .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > index eb5ae28390..bf967880ab 100644 > --- > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > +++ > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > @@ -23,6 +23,7 @@ > /// > > #define > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02 > > > > +#define > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION > 0x04 > > /// > > /// Serial Port Console Redirection Table Format > > /// > > @@ -50,6 +51,37 @@ typedef struct { > UINT32 Reserved3; > > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE; > > > > +/// > > +/// Serial Port Console Redirection Table Format Revision 4 > > +/// > > +typedef struct { > > + EFI_ACPI_DESCRIPTION_HEADER Header; > > + UINT8 InterfaceType; > > + UINT8 Reserved1[3]; > > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress; > > + UINT8 InterruptType; > > + UINT8 Irq; > > + UINT32 > GlobalSystemInterrupt; > > + UINT8 BaudRate; > > + UINT8 Parity; > > + UINT8 StopBits; > > + UINT8 FlowControl; > > + UINT8 TerminalType; > > + UINT8 Reserved2; > > + UINT16 PciDeviceId; > > + UINT16 PciVendorId; > > + UINT8 PciBusNumber; > > + UINT8 PciDeviceNumber; > > + UINT8 PciFunctionNumber; > > + UINT32 PciFlags; > > + UINT8 PciSegment; > > + UINT32 UartClockFrequency; > > + UINT32 PreciseBaudRate; > > + UINT16 > NameSpaceStrLength; > > + UINT16 > NameSpaceStrOffset; > > + CHAR8 > NameSpaceString[0]; > > +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE; > > + > > #pragma pack() > > > > // > > -- > 2.38.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to > be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, > you are > on notice that any distribution of this message, in any form, is > strictly prohibited. Please promptly notify the sender by reply e-mail > or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission= -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118774): https://edk2.groups.io/g/devel/message/118774 Mute This Topic: https://groups.io/mt/105933234/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-