Reviewed-by: Ray Ni <[email protected]> Thanks, Ray ________________________________ From: Tan, Dun <[email protected]> Sent: Friday, May 10, 2024 18:08 To: [email protected] <[email protected]> Cc: Ni, Ray <[email protected]>; Laszlo Ersek <[email protected]>; Kumar, Rahul R <[email protected]>; Gerd Hoffmann <[email protected]>; Wu, Jiaxin <[email protected]> Subject: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting
Remove code to load mtrr setting in CpuS3.c. In previous commits, before transferring to CpuS3.c, MTRR setting has been loaded in S3RestoreConfig2() for all CPU. Signed-off-by: Dun Tan <[email protected]> Cc: Ray Ni <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Jiaxin Wu <[email protected]> --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c index d67fb49890..7ac6b62676 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -91,36 +91,6 @@ UINT8 mApHltLoopCodeTemplate[] = { 0xEB, 0xFC // jmp $-2 }; -/** - Sync up the MTRR values for all processors. - - @param MtrrTable Table holding fixed/variable MTRR values to be loaded. -**/ -VOID -EFIAPI -LoadMtrrData ( - EFI_PHYSICAL_ADDRESS MtrrTable - ) - -/*++ - -Routine Description: - - Sync up the MTRR values for all processors. - -Arguments: - -Returns: - None - ---*/ -{ - MTRR_SETTINGS *MtrrSettings; - - MtrrSettings = (MTRR_SETTINGS *)(UINTN)MtrrTable; - MtrrSetAllMtrrs (MtrrSettings); -} - /** Increment semaphore by 1. @@ -554,8 +524,6 @@ InitializeCpuBeforeRebase ( IN BOOLEAN IsBsp ) { - LoadMtrrData (mAcpiCpuData.MtrrTable); - SetRegister (TRUE); ProgramVirtualWireMode (); -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118843): https://edk2.groups.io/g/devel/message/118843 Mute This Topic: https://groups.io/mt/106018137/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
