Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922
For your convenience, below are two pull requests if you would like to test them. 1) https://github.com/tianocore/edk2/pull/5660 2) https://github.com/tianocore/edk2-platforms/pull/76 I had tried to address review comments as much as I can. Please feel free to let me know if you see any issue in this version of patch set. Thanks, Nickle > -----Original Message----- > From: Nhi Pham <n...@os.amperecomputing.com> > Sent: Tuesday, May 14, 2024 10:26 AM > To: Nickle Wang <nick...@nvidia.com>; devel@edk2.groups.io; > abner.ch...@amd.com; Rebecca Cran <rebe...@bsdio.com> > Cc: Isaac Oram <isaac.w.o...@intel.com>; Attar, AbdulLateef (Abdul Lateef) > <abdullateef.at...@amd.com>; Tinh Nguyen > <tinhngu...@amperemail.onmicrosoft.com> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > External email: Use caution opening links or attachments > > > Thanks Nickle. I will help review and verify your patch. > > On 5/14/2024 8:56 AM, Nickle Wang wrote: > > Hi Nhi, > > > > This task is on my list but with lower priority. I will try to provide > > version 2 patch > for review here by the end of this week. > > > > Thanks, > > Nickle > > > >> -----Original Message----- > >> From: Nhi Pham <n...@os.amperecomputing.com> > >> Sent: Monday, May 13, 2024 5:02 PM > >> To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang > >> <nick...@nvidia.com>; Rebecca Cran <rebe...@bsdio.com> > >> Cc: Isaac Oram <isaac.w.o...@intel.com>; Attar, AbdulLateef (Abdul > >> Lateef) <abdullateef.at...@amd.com>; Tinh Nguyen > >> <tinhngu...@amperemail.onmicrosoft.com> > >> Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: > >> add support for the phosphor ipmi blob transfer protocol > >> > >> External email: Use caution opening links or attachments > >> > >> > >> On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: > >>> [AMD Official Use Only - General] > >>> > >>> Yeah, I forget this patch set and seems we don't have any follow up > >>> conversation > >> after below feedbacks from community. > >>> > >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed > >>> > k2%2F&data=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d > c > >>> > 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 > 6068 > >>> > 8708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJ > >>> > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=%2BCkaU%2FcdG1v > r6uPsA > >>> 7fqrvhvxg%2FX5FqcmJ6fizaa9fA%3D&reserved=0 > >>> .groups.io%2Fg%2Fdevel%2Fmessage%2F103116&data=05%7C02%7Cnickle > w > >> %40nvi > >>> > >> > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > >> 39efd > >>> > >> > 9ccc17a%7C0%7C0%7C638511877469561600%7CUnknown%7CTWFpbGZsb3d8 > >> eyJWIjoiM > >>> > >> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > >> C%7C > >>> &sdata=N4eDH668lBSFxq9r81QrhMgpULvht8isrrEI9lipVKc%3D&reserved=0 > >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed > >>> > k2%2F&data=05%7C02%7Cnicklew%40nvidia.com%7Cdc53be8f0cf24ccfd35108d > c > >>> > 73bd2d45%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C6385125035 > 6070 > >>> > 0897%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJ > >>> > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=KFd86NhmrQeGqEB > 8%2FJy > >>> 0qnbMkb%2Furpo8YCsVbVsOxNk%3D&reserved=0 > >>> .groups.io%2Fg%2Fdevel%2Fmessage%2F103087&data=05%7C02%7Cnickle > w > >> %40nvi > >>> > >> > dia.com%7C8b9e1a8a8d044208f8d608dc732b678d%7C43083d15727340c1b7db > >> 39efd > >>> > >> > 9ccc17a%7C0%7C0%7C638511877469569817%7CUnknown%7CTWFpbGZsb3d8 > >> eyJWIjoiM > >>> > >> > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > >> C%7C > >>> > >> > &sdata=7p0BHb8RFRapFyygr35u0hQBK2bQwKPSypBaUi6cMIQ%3D&reserved=0 > >>> > >>> So Nickle, does NV still has the plan to upstream IPMI blob edk2 > >> implementation? We should keep driving upstream the implementation as > >> industry needs it to incorporate with OpenBMC. > >>> > >>> Hi Rebessa, > >>> As we are on Chinese New Year holidays now, please expect the delay > response. > >>> Thanks > >>> Abner > >>> > >> > >> Hi Nickle and Abner, > >> > >> May I know the status of upstreaming the IPMI Blob Transfer Protocol? > >> I'm planning to upstream the SMBIOS transfer to OpenBMC by leveraging > >> this protocol. > >> > >> Thanks, > >> Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118923): https://edk2.groups.io/g/devel/message/118923 Mute This Topic: https://groups.io/mt/98212643/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-