Reviewed-by: Ray Ni <[email protected]> Thanks, Ray ________________________________ From: Tan, Dun <[email protected]> Sent: Friday, May 17, 2024 17:49 To: [email protected] <[email protected]> Cc: Ni, Ray <[email protected]>; Liming Gao <[email protected]>; Wu, Jiaxin <[email protected]> Subject: [PATCH 6/9] MdeModulePkg:Remove unnecessary global variable
Remove the two unnecessary global variables and replace them by two local variables: mVariableRuntimeNvCacheBufferSize mVariableRuntimeVolatileCacheBufferSize Signed-off-by: Dun Tan <[email protected]> Cc: Ray Ni <[email protected]> Cc: Liming Gao <[email protected]> Cc: Jiaxin Wu <[email protected]> --- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c index 6930875e9f..8b42ae7d72 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c @@ -13,7 +13,7 @@ InitCommunicateBuffer() is really function to check the variable data size. -Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR> +Copyright (c) 2010 - 2024, Intel Corporation. All rights reserved.<BR> Copyright (c) Microsoft Corporation.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent @@ -55,8 +55,6 @@ VARIABLE_STORE_HEADER *mVariableRuntimeNvCacheBuffer = NULL; VARIABLE_STORE_HEADER *mVariableRuntimeVolatileCacheBuffer = NULL; UINTN mVariableBufferSize; UINTN mVariableRuntimeHobCacheBufferSize; -UINTN mVariableRuntimeNvCacheBufferSize; -UINTN mVariableRuntimeVolatileCacheBufferSize; UINTN mVariableBufferPayloadSize; BOOLEAN mVariableRuntimeCachePendingUpdate; BOOLEAN mVariableRuntimeCacheReadLock; @@ -1691,6 +1689,8 @@ SmmVariableReady ( ) { EFI_STATUS Status; + UINTN RuntimeNvCacheSize; + UINTN RuntimeVolatileCacheSize; Status = gBS->LocateProtocol (&gEfiSmmVariableProtocolGuid, NULL, (VOID **)&mSmmVariable); if (EFI_ERROR (Status)) { @@ -1721,16 +1721,16 @@ SmmVariableReady ( // Status = GetRuntimeCacheInfo ( &mVariableRuntimeHobCacheBufferSize, - &mVariableRuntimeNvCacheBufferSize, - &mVariableRuntimeVolatileCacheBufferSize, + &RuntimeNvCacheSize, + &RuntimeVolatileCacheSize, &mVariableAuthFormat ); if (!EFI_ERROR (Status)) { Status = InitVariableCache (&mVariableRuntimeHobCacheBuffer, &mVariableRuntimeHobCacheBufferSize); if (!EFI_ERROR (Status)) { - Status = InitVariableCache (&mVariableRuntimeNvCacheBuffer, &mVariableRuntimeNvCacheBufferSize); + Status = InitVariableCache (&mVariableRuntimeNvCacheBuffer, &RuntimeNvCacheSize); if (!EFI_ERROR (Status)) { - Status = InitVariableCache (&mVariableRuntimeVolatileCacheBuffer, &mVariableRuntimeVolatileCacheBufferSize); + Status = InitVariableCache (&mVariableRuntimeVolatileCacheBuffer, &RuntimeVolatileCacheSize); if (!EFI_ERROR (Status)) { Status = SendRuntimeVariableCacheContextToSmm (); if (!EFI_ERROR (Status)) { -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119045): https://edk2.groups.io/g/devel/message/119045 Mute This Topic: https://groups.io/mt/106150803/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
