As a follow up, I created the following PR to specify the exact version
of queries to use for a given CodeQL CLI release. Now that both are
explicitly specified (the CLI and the query version), there should not
be any mismatch in the future where we're using an older CodeQL CLI
against the latest (incompatible) queries.
https://github.com/tianocore/edk2/pull/5720
On 5/20/2024 9:40 PM, Michael Kubacki wrote:
Just wanted to send a reminder that I recommend
https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for
those that are currently trying to test changes.
Thanks,
Michael
On 5/17/2024 8:10 PM, Kinney, Michael D wrote:
Approved. I agree there is no impact to FW.
Mike
-----Original Message-----
From: Michael Kubacki <mikub...@linux.microsoft.com>
Sent: Friday, May 17, 2024 4:28 PM
To: Kinney, Michael D <michael.d.kin...@intel.com>;
devel@edk2.groups.io;
Andrew Fish <af...@apple.com>; Leif Lindholm
<quic_llind...@quicinc.com>;
Liming Gao <gaolim...@byosoft.com.cn>
Cc: Feng, Bob C <bob.c.f...@intel.com>; Joey Vagedes
<joey.vage...@gmail.com>; Rebecca Cran <rebe...@bsdio.com>; Sean Brogan
<sean.bro...@microsoft.com>; Chen, Christine <yuwei.c...@intel.com>
Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
Forgot about the hard freeze.
Added remaining stewards to consider merging this. It has no impact on
firmware but is needed to unblock an immediate issue in CI where the
CodeQL queries being fetched are newer and incompatible with the CodeQL
CLI being used.
As I mentioned in the release notes, I will follow up in the future for
a change that should be able to lock the CodeQL query versions against
the CLI version.
Thanks,
Michael
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119427): https://edk2.groups.io/g/devel/message/119427
Mute This Topic: https://groups.io/mt/106161774/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
