[AMD Official Use Only - AMD Internal Distribution Only] Hi Rebecca, Having GitHub CODEOWNERS to assign reviewers for the PR is fine to me, as well as only maintainers have the privilege to set "Push" label. I would suggest we use only one CODEOWNERS file on the repo so we can easily find the code owner from that file. I think community should be able to create a PR for updating the CODEOWNERS under any folder on the repo, right? But how can we determine the role of maintainers and reviewers in CODEOWNERS? As only maintainers can set "push" label. Also, how can we identify the newly added code owner has the "push" privilege in the PR against the CODEOWNERS file.
Thanks Abner > -----Original Message----- > From: Rebecca Cran <[email protected]> > Sent: Wednesday, July 3, 2024 10:20 PM > To: [email protected]; [email protected] > Cc: Leif Lindholm <[email protected]>; Michael D Kinney > <[email protected]>; Ard Biesheuvel <[email protected]>; > Chang, Abner <[email protected]>; Attar, AbdulLateef (Abdul Lateef) > <[email protected]>; Grimes, Paul <[email protected]>; Xing, > Eric <[email protected]>; Yao, Ken <[email protected]>; Zhai, MingXin > (Duke) <[email protected]>; Fu, Igniculus <[email protected]>; Nhi > Pham <[email protected]>; Chuong Tran > <[email protected]>; Thomas Abraham > <[email protected]>; Sami Mujawar <[email protected]>; > Ray Ni <[email protected]>; Ilias Apalodimas <[email protected]>; > Andy Hayes <[email protected]>; Wenyi Xie > <[email protected]>; Pedro Falcato <[email protected]>; Marvin > Häuser <[email protected]>; Sai Chaganty > <[email protected]>; Nate DeSimone > <[email protected]>; Liming Gao <[email protected]>; > Eric Dong <[email protected]>; Dandan Bi <[email protected]>; Nickle > Wang <[email protected]>; Kelly Steele <[email protected]>; Zailiang > Sun <[email protected]>; Yi Qian <[email protected]>; Chasel Chiu > <[email protected]>; Benjamin Doron <[email protected]>; > Jeremy Soller <[email protected]>; Daniel Schaefer > <[email protected]>; Sunil V L <[email protected]>; Yuwei Chen > <[email protected]>; Jeremy Linton <[email protected]>; Marcin > Juszkiewicz <[email protected]>; Graeme Gregory > <[email protected]> > Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull > Requests > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 7/1/24 13:16, Rebecca Cran via groups.io wrote: > > Now that edk2 has been using PRs for a few weeks, I'd like to propose > > enabling the same workflow for edk2-platfoms. > > > > As maintainers or reviewers of platforms in the edk2-platforms repo, I'd > > like to get any feedback on moving from email-based reviews to GitHub > > Pull Requests and any concerns or issues people might have with it. > As Leif pointed out, the other question is around assigning reviewers. > > Would people be okay with moving to CODEOWNERS as a method of > assigning > reviewers, moving away from Maintainers.txt? > It's less flexible because it doesn't have the concept of maintainers vs > reviewers, so the idea would be to add both to CODEOWNERS but only allow > maintainers to set the 'push' label or otherwise write to the repository. > > -- > Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119788): https://edk2.groups.io/g/devel/message/119788 Mute This Topic: https://groups.io/mt/106986207/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
