Hi Ard, Thank you for this patch.
These changes look good to me. Reviewed-by: Sami Mujawar <[email protected]> Regards, Sami Mujawar On 25/07/2024, 09:25, "Ard Biesheuvel" <[email protected] <mailto:[email protected]>> wrote: From: Ard Biesheuvel <[email protected] <mailto:[email protected]>> The PSCI reset libraries in ArmPkg are being consolidated into a single one to reduce the maintenance burden of having multiple libraries doing the same thing in a slightly different way. Move the ARM platforms to the generic ArmPsciResetSystemLib, and drop the dependency on ArmSmcPsciResetSystemLib, which is deprecated and will be removed. Cc: Sami Mujawar <[email protected] <mailto:[email protected]>> Cc: Thomas Abraham <[email protected] <mailto:[email protected]>> Signed-off-by: Ard Biesheuvel <[email protected] <mailto:[email protected]>> --- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 3 ++- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc index 1090fbe2a1fc..a793e96f8b0f 100644 --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc @@ -39,7 +39,8 @@ [LibraryClasses.common] # NOR flash identification support NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf - ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf + ResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf + ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc index f7f7b39bbf58..8b9be9e0d372 100644 --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc @@ -97,7 +97,8 @@ [LibraryClasses.common] NorFlashPlatformLib|Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpressLib.inf # NOR flash identification support NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf - ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf + ResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf + ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf # ARM PL031 RTC Driver RealTimeClockLib|ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf -- 2.46.0.rc1.232.g9752f9e123-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120034): https://edk2.groups.io/g/devel/message/120034 Mute This Topic: https://groups.io/mt/107540023/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
