Hi Srikanth, should be fixed by MdeModulePkg: Fix regressions from 11687, 11689. by apop5 * Pull Request #11897 * tianocore/edk2<https://github.com/tianocore/edk2/pull/11897>
From: Aaron Pop <[email protected]> Sent: Tuesday, December 16, 2025 5:16 AM To: Aithal, Srikanth <[email protected]>; Ard Biesheuvel <[email protected]>; [email protected]; [email protected] Cc: Lendacky, Thomas <[email protected]> Subject: Re: [EXTERNAL] Re: [edk2-devel] commit 1097edb4 causes SEV,SEV-ES guest boot fail with AmdSev package Sorry, I lost this in the shuffle. I'll try to reproduce this today. ________________________________ From: Aithal, Srikanth <[email protected]<mailto:[email protected]>> Sent: Tuesday, December 16, 2025 1:39:16 AM To: Ard Biesheuvel <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> Cc: Aaron Pop <[email protected]<mailto:[email protected]>>; Lendacky, Thomas <[email protected]<mailto:[email protected]>> Subject: [EXTERNAL] Re: [edk2-devel] commit 1097edb4 causes SEV,SEV-ES guest boot fail with AmdSev package [You don't often get email from [email protected]<mailto:[email protected]>. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On 12/16/2025 2:37 PM, Ard Biesheuvel wrote: > Some followup fixes were applied to address various issues with this > series of patches. Could you please confirm that the issue still > exists on the latest main branch? Thanks. Yes the issue exists with latest edk2/master[commit 786de86] as well. > > On Tue, 16 Dec 2025 at 05:14, Aithal, Srikanth via groups.io > <[email protected]<mailto:[email protected]>> > wrote: >> Hello Aaron, >> >> just a gentle ping - any chance you could take a look at the regression >> I bisected to the commit below? >> >> Thank you, >> >> On 12/3/2025 5:47 PM, Aithal, Srikanth via groups.io wrote: >>> Hello Aaron, >>> >>> just a gentle ping - any chance you could take a look at the >>> regression I bisected to the commit below? >>> >>> Thank you, >>> >>> >>> On 11/27/2025 3:12 PM, Aithal, Srikanth via groups.io wrote: >>>> Hello, >>>> >>>> AMD SEV and SEV-ES guests built with the AmdSev package currently >>>> fail to boot on EDK2 master (other build packages work fine). Booting >>>> the same guests by passing -kernel and -append params works without >>>> issues. >>>> >>>> The following commit seems to be the culprit: >>>> >>>> /commit 1097edb4c3eac1daf8161f8618a3eb7c81840c98 >>>> Author: Aaron Pop <[email protected]<mailto:[email protected]>> >>>> Date: Wed Oct 22 11:33:02 2025 -0700 >>>> >>>> MdeModulePkg: Fix missing NULL tests. >>>> >>>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgithub%2Fcodeql%2Fblob%2Fcodeql-cli-2.7.3%2Fcpp%2Fql%2Fsrc%2FCritical%2FMissingNullTest.qhelp&data=05%7C02%7Caaronpop%40microsoft.com%7C5a59a77f591245588ec508de3c86fe36%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C639014747664150350%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=rI5ZddSGCrP9lB6elZczMQiaJbrXQ3wKv%2FBWbMzSmB4%3D&reserved=0<https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp> >>>> >>>> >>>> For items which allocate memory, or get a pointer from another >>>> structure, it is important to validate that the pointers >>>> are not null before they are dereferenced. >>>> >>>> Signed-off-by: Aaron Pop >>>> <[email protected]<mailto:[email protected]>> >>>> >>>> MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 26 >>>> +++++++++++------- >>>> .../BootManagerPolicyDxe/BootManagerPolicyDxe.c | 3 +-- >>>> .../DriverHealthManagerDxe.c | 21 +++++++++++---- >>>> .../EbcDxe/EbcDebugger/EdbSupportString.c | 5 +++- >>>> .../Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 5 +++- >>>> .../FaultTolerantWritePei/FaultTolerantWritePei.c | 6 ++++- >>>> .../PlatformDriOverrideDxe/PlatDriOverrideDxe.c | 24 >>>> ++++++++++++----- >>>> .../PlatformDriOverrideDxe/PlatDriOverrideLib.c | 31 >>>> +++++++++++++++++----- >>>> .../Smm/ReportStatusCodeRouterCommon.c | 5 +++- >>>> 9 files changed, 93 insertions(+), 33 deletions(-)/ >>>> >>>> Sev-es guest qemu launch command: >>>> >>>> qemu-system-x86_64 \ >>>> -machine q35,confidential-guest-support=sev0,vmport=off \ >>>> -object >>>> sev-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,kernel-hashes=on,policy=3 >>>> \ >>>> -name guest=vm,debug-threads=on \ >>>> -drive >>>> if=pflash,format=raw,unit=0,file=/usr/local/AmdSev/OVMF.fd,readonly \ >>>> -cpu host \ >>>> -m 2048 \ >>>> -smp 1,maxcpus=1,cores=1,threads=1,dies=1,sockets=1 \ >>>> -drive id=disk0,file=24.04-server.qcow2,format=qcow2,if=none \ >>>> -device virtio-scsi-pci,id=scsi0,disable-legacy=on,iommu_platform=true \ >>>> -device scsi-hd,drive=disk0 \ >>>> --enable-kvm \ >>>> --nographic >>>> >>>> Guest boot serial log extract: >>>> >>>> [Bds]OsIndication: 0000000000000000 >>>> [Bds]=============Begin Load Options Dumping ...============= >>>> Driver Options: >>>> SysPrep Options: >>>> Boot Options: >>>> Boot0000: BootManagerMenuApp 0x0109 >>>> Boot0001: EFI Firmware Setup 0x0101 >>>> Boot0002: Grub Bootloader 0x0001 >>>> PlatformRecovery Options: >>>> [Bds]=============End Load Options Dumping============= >>>> [Bds]BdsWait ...Zzzzzzzzzzzz... >>>> [Bds]Exit the waiting! >>>> Memory Previous Current Next >>>> Type Pages Pages Pages >>>> ====== ======== ======== ======== >>>> 0A 00000080 00000022 00000080 >>>> 09 00000010 0000000C 00000010 >>>> 00 00000080 00000038 00000080 >>>> 05 00000100 0000003C 00000100 >>>> 06 00000100 000000B3 00000100 >>>> [Bds]Booting Grub Bootloader >>>> [Bds] Expand >>>> Fv(7CB8BDC9-F8EB-4F34-AAEA-3EE4AF6516A1)/FvFile(B5AE312C-BC8A-43B1-9C62-EBB826DD5D07) >>>> -> <null string> >>>> BdsDxe: failed to load Boot0002 "Grub Bootloader" from >>>> Fv(7CB8BDC9-F8EB-4F34-AAEA-3EE4AF6516A1)/FvFile(B5AE312C-BC8A-43B1-9C62-EBB826DD5D07): >>>> Not Found >>>> [Bds] Unable to boot! >>>> BdsDxe: No bootable option was found. >>>> >>>> If the issue is fixed please add tag "Reported-by: Srikanth Aithal >>>> <[email protected]<mailto:[email protected]>>" >>>> >>>> >>>> Thank you >>>> >>>> Srikanth Aithal >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121727): https://edk2.groups.io/g/devel/message/121727 Mute This Topic: https://groups.io/mt/116498544/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
