Hi, > > Also note that OVMF already has an incompatible pci device driver and > > there can be only one instance, so the code must be merged into the > > existing driver instead of adding a second. > > I checked OvmfPkg/IncompatiblePciDeviceSupportDxe -- its CheckDevice() > is unconditional, it returns the same 64-bit-MMIO-preference descriptor > for every device regardless of VendorId/DeviceId. Merging Fixed BAR > design in would make it a simple dispatch: if the device has an entry in > the fw_cfg blob we export, return our descriptor; otherwise fall through > to the existing behavior unchanged. Does that match what you had in > mind, or is there a different integration point you'd prefer?
For the most part yes. I'd suggest to keep the fixed-bars code in a separate source file, then just add a small dispatch hook to the existing CheckDevice function. In case there is a fixed-bars entry use that instead of the hardcoded template. The option rom tweak for confidential VMs should be applied to the fixed-bars entries too, so don't return early. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#122153): https://edk2.groups.io/g/devel/message/122153 Mute This Topic: https://groups.io/mt/120952983/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
