I've commited a patch that adds a reply configuration variable (boolean) to emi2 and at2.
I've tested it with an test account and I won't be able to put it in production machines for a week or two BTW... What is a +1 in STATUS * smsc_emi2.c does not try to re-connect if the initial login attempt fails, this causes a problem if the session timeout of the provider has yet not been taken place and the bearerbox may connect in a couple of minutes later. Suggested solution: global configuration directive is a smsc driver should attempt to loop for re-connceting to the smsc. Posted by: "Angel Fradejas" <[EMAIL PROTECTED]> Message-ID: <[EMAIL PROTECTED]> Status: Stipe +1 (on concept) ----- Original Message ----- From: "Angel Fradejas" <[EMAIL PROTECTED]> To: "Kannel Developers" <[EMAIL PROTECTED]> Sent: Monday, February 11, 2002 9:06 AM Subject: [REPOST] [PATCH] emi2 driver login behaviour I just noted this is appears as an open issue in STATUS, but not as an available patch. Just in case you missed it, here is it again. -----Mensaje original----- De: Angel Fradejas [mailto:[EMAIL PROTECTED]] Enviado el: miércoles 30 de enero de 2002 11:13 Para: Stipe Tolj CC: Kannel Developers Asunto: [PATCH] emi2 driver login behaviour Yes, I know that's my provider problem. I just wanted to point out a situation where a re-connect loop is a must. Find attached the patch for that. Index: gw/smsc_emi2.c =================================================================== RCS file: /home/cvs/gateway/gw/smsc_emi2.c,v retrieving revision 1.39 diff -u -r1.39 smsc_emi2.c --- gw/smsc_emi2.c 2002/01/17 07:52:39 1.39 +++ gw/smsc_emi2.c 2002/01/30 09:47:56 @@ -237,10 +237,9 @@ if (result == -2) { /* Are SMSCs going to return any temporary errors? If so, * testing for those error codes should be added here. */ - error(0, "smsc_emi2: Server rejected our login, giving up"); - conn->why_killed = SMSCCONN_KILLED_WRONG_PASSWORD; + error(0, "smsc_emi2: Server rejected our login, retrying"); conn_destroy(server); - return NULL; + continue; } else if (result == 0) { error(0, "smsc_emi2: Got no reply to login attempt " -----Mensaje original----- De: Stipe Tolj [mailto:[EMAIL PROTECTED]] Enviado el: martes 29 de enero de 2002 21:47 Para: Angel Fradejas CC: Kannel Developers Asunto: Re: [RFC] emi2 driver login behaviour Angel Fradejas wrote: > > My EMI2 provider from time to time leaves my connections in a zombie state: > althought I closed it, they see them as already open (they have problems > with their soft I guess). The result is that when I try to login again they > reject me with a "number of sessions exceeded" reason. > > Eventually, the sessions they have will die and I will be able to login. This session misbehaviour/limit is definitly on the server side (your provider). > Others drivers will sleep and try again. I think this is the way to go, as > Kannel is meant to run 24/7 mostly unattended. The modifications needed to > do that are trivial. I have done it with good results. > > What do you think? I think looping in order to try to re-connect is a thing we should take into account here. Can you provide us a patch against current cvs and we are going to incorporate it. BTW, I added this issue to STATUS. Stipe [EMAIL PROTECTED] ------------------------------------------------------------------- Wapme Systems AG Münsterstr. 248 40470 Düsseldorf Tel: +49-211-74845-0 Fax: +49-211-74845-299 E-Mail: [EMAIL PROTECTED] Internet: http://www.wapme-systems.de ------------------------------------------------------------------- wapme.net - wherever you are