Hi All,
Bug:
If the SMPP driver receives a successful submit_sm_resp with a NULL
message_id field
and a submission report was requested then Kannel panics.
Yes, Sending a submit response without a message_id is incorrect according
to specification
but if it does happen Kannel should not fall over.
Kannel falls over as dlr_add tries to do a octstr_get_cstr on the message id
variable (tmp)
that is NULL.
Queries:
Should the SMPP driver treat message queue full errors in a similar manner
to throttling errors
as I think some SMSC operators request this behaviour. And it makes sense to
retry a message that
receives a message queue full error.
When a message is sent requesting a submission report, why does the SMPP
driver save the
message to the store if the response is successful and not save the message
if the
response is unsuccessful. Surely the behaviour should be the same regardless
of
failed or succeeded. It also seems to be inefficient if only requesting
submission reports
and not delivery reports!
Within the SMPP driver there is the following line for throttling messages:
if (transmitter &&
(!smpp->throttling_err_time ||
((time(NULL) - smpp->throttling_err_time) > SMPP_THROTTLING_SLEEP_TIME
&& !(smpp->throttling_err_time = 0)))
/* >>> looks dangerous
*/
)
send_messages(smpp, conn, &pending_submits);
AFAIK the code is correct but why is the assigning of 0 to the
smpp->throttling_err_time part of the
condition evaluation, I would suggest that this would be easier to
understand if it was extracted out of
the if statement.
if (transmitter &&
(!smpp->throttling_err_time ||
(time(NULL) - smpp->throttling_err_time) > SMPP_THROTTLING_SLEEP_TIME)
)
{
smpp->throttling_err_time = 0; /* set for when the throttling time
expires. */
send_messages(smpp, conn, &pending_submits);
}
comments appreciated!
Mike.
ANAM Wireless Internet Solutions
http://www.anam.com mailto:[EMAIL PROTECTED]
+353 1 284 7555
Castle Yard, Saint Patrick's Road, Dalkey, County Dublin, Ireland
