Hi

Why not just use the iconv support that is allready present in some of the smsc modules?

Nisan
At 03:46 PM 6/18/03 +0200, Andreas Fink wrote:

On Mercredi, juin 18, 2003, at 03:39  Uhr, Antonis Spirou wrote:

I hope i did it ok..

We needed to map greek  characters according to GSM 338

So there it is..

Antonis

there's no way of mapping something on one side to map to something which doesn't exist.

This line is invalid C code:
                //91, /* A dieresis */

(// is valid in C++ but not in ANSI C, even gcc accepts it)

those lines:

-       'E', /* approximate E grave */
+       25, /* theta greek */

will probably mean it works in greece but breaks compatibility in other countries.
I vote -1 for this patch as is. Proper implementation of greek has to be made different. ISO-8859-1 is also not appropriate so there's more to this.


Andreas Fink
Global Networks Switzerland AG

------------------------------------------------------------------
Tel: +41-61-6666333  Fax: +41-61-6666334   Mobile: +41-79-2457333
Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland
Web: http://www.global-networks.ch/      [EMAIL PROTECTED]
------------------------------------------------------------------


</blockquote></x-html>

Reply via email to