Hi!

I agree that your way is a better approach, but we needed something a bit
fast and I saw some other ppl before in need for something like this. I'll
see if I can do some work on what you are talking about, do you having
anything to provide or should I start from scratch? There is alot of other
things that this approach could be useful for aswell!

/ S

-----Original Message-----
From: Stipe Tolj [mailto:[EMAIL PROTECTED] 
Sent: den 9 november 2003 15:34
To: Stefan Cars
Cc: [EMAIL PROTECTED]
Subject: Re: Patch, setting source_addr_ton when sending the messages

Stefan Cars wrote:
> 
> This patch allows you to set the source_addr_ton when sending the SM 
> by using a new cgi var called "source-addr-ton". This is necessary 
> when speaking to some providers. Maybe the same thing should be done 
> for the NPI aswell, but I have not come across any case where that would
be necessary.

-1

Reasons: smsbox should not encapsulate SMSC module specific information,
like in this case SMPP's TON and NPI values.

Solution: it should be applicable to have a "virtual smsc-id" that maps to
the "real smsc-id" connection and sets alternative values, ie.

  group = smsc
  smsc = smpp
  smsc-id = <real-id>
  host = ...
  smsc-username = ...
  source-addr-ton = 1
  ...

  group = smsc
  smsc = <real-id>
  smsc-id = <virt-id>
  source-addr-ton = 5
  ...

which means if you send via sendsms a request with CGI vars
..&smsc=<real-id> the source address TON would be forced to 1, if you send
...&smsc=<virt-id> then the <real-id> connection is used, but source
address TON would be 5.

In this sense you can abstract the dirfferences within smsc modules without
"overfreighting" smsbox's interface with specific CGI vars.

BTW, I tried to implement these kind of beasts. Unfortunatly it's not
trivial and yet not finished on my side. If anyone can/did work on this,
please provide patches, they are always welcome ;)

Stipe

mailto:[EMAIL PROTECTED]
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf, NRW, Germany

phone: +49.211.74845.0
fax: +49.211.74845.299

mailto:[EMAIL PROTECTED]
http://www.wapme-systems.de/
-------------------------------------------------------------------

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.2.2 (Cygwin)

mIsEP6mcYwEEAMDnUiUwrbb+xwTFWN6TxF2+XZu7/alwJMeCwMBRvXtPZqfjpPhS
OkBpU0F4TrVuugz1HINTSaJTYq10AzDQXp5NkyWgckqW79nPAWuOX0dicbJk+cN2
nM2TI4KaxUDe6u8hghNEnH/i2lXsUu9apnP/iixzV81VC2je3uc9hZpnAAYptEVT
dGlwZSBUb2xqIChUZWNobm9sb2d5IENlbnRlciAmIFJlc2VhcmNoIExhYikgPHRv
bGpAd2FwbWUtc3lzdGVtcy5kZT6ItAQTAQIAHgUCP6mcYwIbAwYLCQgHAwIDFQID
AxYCAQIeAQIXgAAKCRABV0w1BqPYRuSqA/wPzsQxao2YePENCtgRTrO86U6zg3sl
OcS6CJFI4FZP5h/xD3GRsNH1+MPSvZlomDdpFnr547DGz/Kq9MXuQwVvlVig5yWZ
K5dtKp1r5YLhxJQBhfirZbRFFnYmf19f18J8OoS28tuFVftDl1AIwJS3HLyBTv6H
g2HyLAEKQIp30Q==
=aYCI
-----END PGP PUBLIC KEY BLOCK-----



Reply via email to