is ok according the rfc 2616. (Because this is a low level parsing function, you definitely want to test.)
Aarno
On 27.1.2005, at 13:04, Stipe Tolj wrote:
Ok,
regarding the Siemens SX1 kludge and the WSP headers with <end-of-string> as only value byte, I'd like to get at least a vote for commiting this patch from the following developers:
Aarno, Paul, Slava
please.
You guys haven't stated yet nothing regarding a vote. Please do so. I'd like to keep it that way in order to have a negotiated consensus.
Stipe
mailto:stolj_{at}_wapme.de ------------------------------------------------------------------- Wapme Systems AG
Vogelsanger Weg 80 40470 Düsseldorf, NRW, Germany
phone: +49.211.74845.0 fax: +49.211.74845.299
mailto:info_{at}_wapme-systems.de http://www.wapme-systems.de/ -------------------------------------------------------------------
Index: wap/wsp_headers.c =================================================================== RCS file: /home/cvs/gateway/wap/wsp_headers.c,v retrieving revision 1.19 diff -u -r1.19 wsp_headers.c --- wap/wsp_headers.c 8 Aug 2004 20:39:56 -0000 1.19 +++ wap/wsp_headers.c 21 Jan 2005 01:11:50 -0000 @@ -110,7 +110,7 @@ unsigned long len;
val = parse_get_char(context); - if (val >= 0 && val < 31) { + if (val > 0 && val < 31) { *well_known_value = -1; parse_limit(context, val); return WSP_FIELD_VALUE_DATA; @@ -126,7 +126,7 @@ *well_known_value = -1; /* We already consumed the Quote */ return WSP_FIELD_VALUE_NUL_STRING; - } else { + } else { /* implicite val == 0 */ *well_known_value = -1; /* Un-parse the character we just read */ parse_skip(context, -1);
