Hi,

Only in the case of DLR_SMSC_SUCCESS, not in DLR_SMSC_FAIL. I would still prefer not to create DLRs all over the place but have a single dlr_add for all.

Nevertheless this has nothing to do with your patch. +1.

BR,
Nikos
----- Original Message ----- From: "Arne K. Haaje" <a...@drlinux.no>
To: "Nikos Balkanas" <nbalka...@gmail.com>
Cc: <devel@kannel.org>
Sent: Thursday, February 19, 2009 5:20 PM
Subject: Re: [PATCH] SMPP: With dlr-mask=24, foreign_id is not set


Yes,

bb_smscconn_sent(smpp->conn, msg, NULL) (just outside context in the patch) sends this using create_dlr_from_msg, so avoids creating a dlr with dlr_add.


On Torsdag 19 februar 2009 16:11:47 Nikos Balkanas wrote:
Hi,

I am not sure I understand this. With dlr-mask=24 you are asking DLRs only for SMSC_SUCCESS or SMSC_FAIL. You are not asking DLRs for overall success
or fail. To get  even dlr-url called, you need to have a dlr. Yet for all
other cases (0x07) code calls dlr_add but not for 0x18 (24).  Are you
getting a DLR at all?

BR,
Nikos
----- Original Message -----
From: "Arne K. Haaje" <a...@drlinux.no>
To: <devel@kannel.org>
Sent: Thursday, February 19, 2009 4:51 PM
Subject: [PATCH] SMPP: With dlr-mask=24, foreign_id is not set

> If you have dlr-mask=24, to only receive ACK or NACK, then foreign_id > is
> not
> set on the dlr-url for %F when receiving ACK from the operator.
>
> This small patch should set it.
>
> Arne
> --
> --------------------------------
> Arne K. Haaje | www.drx.no
> T: 69 51 15 52 | M: 92 88 44 66
> --------------------------------

--
--------------------------------
Arne K. Haaje | www.drx.no
T: 69 51 15 52 | M: 92 88 44 66
--------------------------------


Reply via email to