Hi Rene,

In my previous comment I said that making alt_charset is not necessary since by using a full iso and decoding with the same one, it would yield the original without errors, although it would be preferable to make it configurable.

It turns out that not doing so, it would contradict kannel architecture. In such a content bearerbox, doesn't try simply to recover original charset, rather with alt_charset it tries to convert it to a new charset compatible with the smsc. therefore it is necessary to make it configurable.

Since the list of features/client connection should be epandable, I would recommend skipping the text file alltogether and instead create a new configuration group, ie:

group = client
...

PS: Charset code was lift off gw/smsc/smsc_smpp.c. It needs to be converted to UTF-8 as well.

BR,
Nikos
----- Original Message ----- From: Rene Kluwen
To: 'Nii Ako Ampa-Sowa' ; devel@kannel.org
Sent: Monday, May 09, 2011 1:39 AM
Subject: RE: [PATCH] handling of non-latin GSM subset in opensmppbox


Patch committed. Current revision of opensmppbox is 61.

Still todo: Make a configuration entry for alt-charset. Even though it is not really necessary at the moment.

Log line:

2011-05-09 Rene Kluwen <rene.kluwen at chimit.nl>
* gw/opensmppbox.c: Default GSM character set is converted to UTF-8 (Kannel's internal way of exchanging messages). The facilitates foreign (e.g. greek) characters.
   Thanks to Nii Ako Ampa-Sowa (ampasowa at gmail.com) for the patch.

== Rene


From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf Of Nii Ako Ampa-Sowa
Sent: Friday, 06 May, 2011 23:04
To: devel@kannel.org
Subject: [PATCH] handling of non-latin GSM subset in opensmppbox

Hi,

opensmppbox doesn't seem to handle the non-Latin subset of the GSM character set very well. This affects the Euro sign as well as Greek characters. Attached is a patch that switches from using the Latin1 conversion routine to the UTF-8 version.

Nii

Reply via email to