Hi, commited to SVN, thanks!
Alex Am 07.10.2013 um 18:35 schrieb Jacek Raczkiewicz <jacek.raczkiew...@gmail.com>: > Werner, > > You are absolutely right, thanks for pointing this out. > I have fixed it - I hope for good this time. > > Patch attached. > > Regards, > Jacek > > > 2013/10/4 Werner Coetzee <werner.coet...@clickatell.com> > > > > Werner Coetzee - Senior C Developer > > E: werner.coet...@clickatell.com > T: 27 21 910 7700 F: 27 21 910 7701 > > > This e-mail message and all attachments transmitted with it are confidential > and are intended solely for the addressee(s). If the reader of this message > is not the intended recipient, you are hereby notified that any reading, > dissemination, distribution, copying, or other use of this message or its > attachment(s) is strictly prohibited. Clickatell does not recognise that a > contract can be concluded by way of electronic communication. All contracts > must be signed on paper and only authorised signatories in terms of the > Clickatell Authorised Signatory Policy may contract on behalf of Clickatell. > All provisions to the contrary contained in the Electronic Communications and > Transactions Act 25 of 2002 are hereby specifically excluded. > > Hi > > > > I believe there is one downside to this implementation though. > > > > If you're running with log level and output level (for stderr) the same, the > formatting will be done twice if I'm not mistaken. > > Or if you have multiple log files the formatting will be done multiple times > (but only in the FUNCTION_GUTS macro since it loops through all logs). > > > > Simple enough to fix though. > > > > Regards > > Werner > > > > > > From: devel [mailto:devel-boun...@kannel.org] On Behalf Of Jacek Raczkiewicz > Sent: 04 October 2013 09:14 > To: Alexander Malysh > Cc: devel@kannel.org > Subject: Re: [Patch] Improve logging function > > > > Hi, > > > > Ok I have fixed my patch and attached in the email. > > I miss-understood the locking here, mea culpa. > > > > Jacek > > > > 2013/10/3 Alexander Malysh <amal...@kannel.org> > > Hi, > > for improvement +1 for the implementation -1. You change a way how we used > rwlock . Rwlock is to protect > log file list and not the output. Please keep rwlock in place then +1 from me. > > Alex > > Am 02.10.2013 um 17:52 schrieb Jacek Raczkiewicz > <jacek.raczkiew...@gmail.com>: > > > > Hi, > > > > I have been working on imrpving application that uses a lot libraries from > > kannel/gwlib. > > I noticed that logging function does format the string even if there is no > > intention to save it to the log due to configured log level. > > My improvement is that I moved the format() function inside the conditional > > block which check for log level. > > This really make a difference when logged string is large (in our case it > > may be as big as 1MB) and that is formatted for no reason. > > > > Please include this fix into kannel codebase. > > > > Regards > > Jacek Raczkiewicz > > > <logging.diff> > > > > > > > <fixed_logging.diff>
