Technically, you can obtain the protocol from the smsc-id. I don't think we need to specify it in the group = tlv.
cheers, MAG On Wed, 2014-07-16 at 17:35 +0200, Alexander Malysh wrote: > Hi, > > > idea is good but TLV is SMPP specific IMHO. Therefore I would not > expect this as generic :-) > > > Patch is hardcoded on many places. If you do it generic then please do > it instead of just to name it so. > I would expect generic config groups that have proto inside of group > and SMPP PDU just > fetch with constant they part instead of oct_imm("smpp-tlv"). > > > so the group would be: > > > group = tlv (Hier we have to think about better name, TLV is > confusing) > protocol = smpp/ucp/cimd2 > name = xxx > tag = xxx > length = xxx > type = INTEGER/OCTSTR/NULTERMINATED > smsc-id = xxx;xxx1 > > > Then SMPP PDU will just fetch by proto: > > > generic_tlv_get_by_tag(TLV_PROTO_SMPP, smsc_id, tag); > > > > > And please avoid using typedefs it's really bad > style: > http://discuss.fogcreek.com/joelonsoftware1/default.asp?cmd=show&ixPost=10506 > > > Alex > > Am 16.07.2014 um 16:40 schrieb Stipe Tolj <st...@kannel.org>: > > > Am 10.07.2014 19:59, schrieb marc-andre.gat...@gameloft.com: > > > Hi, > > > > > > I'm using the meta-data to get the E50_HPLMN and set the E50_AC. > > > > > > here's the patch to support that for the EMI protocol. If you guys > > > have > > > a better way of doing so please feel free to give me a hint. > > > > > > I'd like to apply the patch in the main repo asap. > > > > Hi Mark, > > > > thanks a lot for the patch, we appreciate your willingness to > > contribute. > > > > In fact I had this being tackled in a more generic way, pulling the > > SMPP TLV code out of the SMPP specific modules into a generic > > gw/generic_tlv.[ch] module that can be used by any SMSC module. > > > > Please find it attached to this mail for review and voting for > > commiting to svn trunk. (Though, this WILL go into svn post > > 1.4.4-stable release). > > > > The SMPP module is modified accordingly, along with additions for > > CIMD2. I'm sure you will be able to add EMI/UCP too using the same > > function set. > > > > Stipe > > > > -- > > ------------------------------------------------------------------- > > Kölner Landstrasse 419 > > 40589 Düsseldorf, NRW, Germany > > > > Kannel Foundation tolj.org system architecture > > http://www.kannel.org/ http://www.tolj.org/ > > > > mailto:stolj_{at}_kannel.org mailto:st_{at}_tolj.org > > ------------------------------------------------------------------- > > <gateway-generic-tlv.diff> > >