Hank,

Thank you very much for your feedback.

On Thu, Jun 17, 2010 at 1:23 PM, Henk de Groot <[email protected]> wrote:
> The only problem I see is a
> possible complained from the compiler because of an argument that's defined
> but never used. The only way around that is to avoid the call to the
> function in the first place by using compiler directives in the code (or use
> a #define but that solution was already rejected). Disabling the call to the
> function in the code may even save some more overhead and make the memory
> footprint smaller.

I thought about using #ifdefs in the code too but then read in
Documentation/SubmittingPatches:

2) #ifdefs are ugly

Code cluttered with ifdefs is difficult to read and maintain.  Don't do
it. Instead, put your ifdefs in a header, and conditionally define
'static inline'

So I discard this option. Do you want me to do it anyway and send a
new patch? I'm willing to solve it the right way.

Thanks a lot.

Best regards,

-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to