+     if (likely(hw != NULL))
+             wl = hw->priv;

This isn't a fast path.  The likely() here is not needed.  It makes the
code less readable for no reason.

Good suggestion. Agree.

Come to think about it a bit better: I would say that the 'likely' makes the code more readable since it indicates to the reader what the 'sunny flow' is. Is there a common consensus on the usage of likely/unlikely ?

Bye,

Roland Vossen.

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to