> -----Original Message----- > From: Christoph Hellwig [mailto:[email protected]] > Sent: Monday, May 23, 2011 2:43 PM > To: KY Srinivasan > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Hank Janssen; Haiyang Zhang > Subject: Re: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out > of staging > > > +#include <linux/version.h> > > This one shouldn't be needed.
Correct; I will fix this. > > > +#include <asm/hyperv.h> > > +#include <asm/mshyperv.h> > > not really a review for this driver, but what's the purpose if having > these two headers? These header files have the defines for checking if we are running on Hyper-V. > > Shouldn't the Kconfig entry also move from drivers/staging to > arch/x86 towards the other clocksources? Currently this driver is built if HYPERV is defined. I agree with you that I should have Kconfig entry in arch/x86. Since the rest of the Hyper-V drivers are still in staging, I am thinking that perhaps we should have a different config switch - HYPERV_CLKSRC. I will go ahead and spin a new version of this patch with this change. Regards, K. Y _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
