Dan Carpenter <[email protected]> writes:

> On Mon, Jun 27, 2011 at 06:36:10PM +0300, Kalle Valo wrote:
>
>> +void ar6000_testmode_rx_report_event(struct ar6_softc *ar, void *buf,
>> +                                 int buf_len)
>> +{
>> +    kfree(ar->tcmd_rx_report);
>> +
>> +    ar->tcmd_rx_report = kmemdup(buf, buf_len, GFP_KERNEL);
>> +    ar->tcmd_rx_report_len = buf_len;
>> +
>
> Can this race?  When we use tcmd_rx_report_len we are under lock,
> but it seems like when we set it here, we're not under lock.

Yes, it can. I'll fix it in v2.

Thanks again for good comments.

-- 
Kalle Valo
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to