On Wed, Jun 29, 2011 at 04:46:41PM -0700, Franky Lin wrote:
> #define FOREACH_BSS(wlc, idx, cfg) \
> - for (idx = 0; (int) idx < WLC_MAXBSSCFG; idx++) \
> - if ((cfg = (wlc)->bsscfg[idx]))
> + for (idx = 0, cfg = (wlc)->bsscfg[idx]; \
> + idx < WLC_MAXBSSCFG; cfg = (wlc)->bsscfg[++idx]) \
> + if (cfg)
>
That's pretty ugly. Better to leave the original in and ignore the
checkpatch warning. Or maybe do something like this:
for (idx = 0; (int) idx < WLC_MAXBSSCFG; idx++) { \
cfg = (wlc)->bsscfg[idx]; \
if (!cfg) \
continue; \
Then #define END_FOREACH_BSS() }
Btw, this patchset has over 100 patches so unless there is something
drastically wrong lets just apply it as is and fix up any complaints
that people have in later patches. It sucks when people resend huge
patchsets and we have to review everything again.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
