On Fri, Jul 22, 2011 at 12:57:35PM +0530, Ravishankar wrote:
> @@ -322,10 +321,11 @@ static int das6402_attach(struct comedi_device *dev,
> if (iobase == 0)
> iobase = 0x300;
>
> - printk(KERN_INFO "comedi%d: das6402: 0x%04lx", dev->minor, iobase);
> + pr_info("comedi%d: das6402: 0x%04lx", dev->minor, iobase);
>
> if (!request_region(iobase, DAS6402_SIZE, "das6402")) {
> - printk(KERN_CONT " I/O port conflict\n");
> + pr_cont("I/O port conflict\n");
> + dev_dbg(dev->hw_dev, "I/O port conflict\n");
Why are we printing this out twice here?
Really, I think maybe you shouldn't be sending cleanup patches. It
looks easy but it's actually tricky. Kernel programming is not a
very good or very fun place for learners. Sorry for this. :/
> return -EIO;
> }
> dev->iobase = iobase;
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
