From: Ravishankarkm <[email protected]>

This is a patch to the cb_pcidas64.c file that fixes up a printk warning found 
by the checkpatch.pl tool

Signed-off-by: Ravishankarkm <[email protected]>
---
 drivers/staging/comedi/drivers/cb_pcidas64.c |   22 ++++++++++------------
 1 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c 
b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1e32419..599bad1 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1739,7 +1739,7 @@ static int attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
        uint32_t local_range, local_decode;
        int retval;
 
-       printk("comedi%d: cb_pcidas64\n", dev->minor);
+       pr_info("comedi%d: cb_pcidas64\n", dev->minor);
 
 /*
  * Allocate the private structure area.
@@ -1776,17 +1776,17 @@ static int attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
        }
 
        if (dev->board_ptr == NULL) {
-               printk
-                   ("No supported ComputerBoards/MeasurementComputing card 
found\n");
+               pr_warn("No supported "
+                               "ComputerBoards/MeasurementComputing card 
found\n");
                return -EIO;
        }
 
-       printk("Found %s on bus %i, slot %i\n", board(dev)->name,
-              pcidev->bus->number, PCI_SLOT(pcidev->devfn));
+       pr_info("Found %s on bus %i, slot %i\n",
+                       board(dev)->name, pcidev->bus->number,
+                       PCI_SLOT(pcidev->devfn));
 
        if (comedi_pci_enable(pcidev, driver_cb_pcidas.driver_name)) {
-               printk(KERN_WARNING
-                      " failed to enable PCI device and request regions\n");
+               pr_warn(" failed to enable PCI device and request regions\n");
                return -EIO;
        }
        pci_set_master(pcidev);
@@ -1814,7 +1814,7 @@ static int attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
 
        if (!priv(dev)->plx9080_iobase || !priv(dev)->main_iobase
            || !priv(dev)->dio_counter_iobase) {
-               printk(" failed to remap io memory\n");
+               pr_warn(" failed to remap io memory\n");
                return -ENOMEM;
        }
 
@@ -1850,17 +1850,15 @@ static int attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
 
        priv(dev)->hw_revision =
            hw_revision(dev, readw(priv(dev)->main_iobase + HW_STATUS_REG));
-       printk(" stc hardware revision %i\n", priv(dev)->hw_revision);
        init_plx9080(dev);
        init_stc_registers(dev);
        /*  get irq */
        if (request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
                        "cb_pcidas64", dev)) {
-               printk(" unable to allocate irq %u\n", pcidev->irq);
+               pr_warn(" unable to allocate irq %u\n", pcidev->irq);
                return -EINVAL;
        }
        dev->irq = pcidev->irq;
-       printk(" irq %u\n", dev->irq);
 
        retval = setup_subdevices(dev);
        if (retval < 0)
@@ -1882,7 +1880,7 @@ static int detach(struct comedi_device *dev)
 {
        unsigned int i;
 
-       printk("comedi%d: cb_pcidas: remove\n", dev->minor);
+       pr_info("comedi%d: cb_pcidas: remove\n", dev->minor);
 
        if (dev->irq)
                free_irq(dev->irq, dev);
-- 
1.7.6

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to