Hi Dan,

On Sun, Jul 1, 2012 at 9:02 PM, Dan Carpenter <[email protected]> wrote:
> On Sun, Jul 01, 2012 at 07:12:07PM +0530, Devendra Naga wrote:
>> as comedi_alloc_subdevices may fail, we leak out the memory allocated by 
>> alloc_private,
>> and also the I/O regions we requested.
>>
>> free out the private data pointer of the driver, and release the I/O regions.
>>
>> Signed-off-by: Devendra Naga <[email protected]>
>
> This breaks the build.

dev->priv should be dev->private. I was in a hurry to send the fix and
didn't build tested,
>
> Also Hartley and Ian, what's the point of alloc_private()?  It's
> just hiding stuff which we need to know about and use later on
> anyway.
>
> regards,
> dan carpenter
>
>

sorry again,

Devendra.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to