On Tue, Oct 2, 2012 at 9:12 PM, Andy Shevchenko <[email protected]> wrote: > On Tue, 2012-10-02 at 20:53 +0900, YAMANE Toshiaki wrote: >> fixed below checkpatch error. >> >> -ERROR: trailing whitespace >> >> Signed-off-by: Toshiaki Yamane <[email protected]> >> --- >> drivers/staging/rts_pstor/trace.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rts_pstor/trace.h >> b/drivers/staging/rts_pstor/trace.h >> index cf60a1b..740999c 100644 >> --- a/drivers/staging/rts_pstor/trace.h >> +++ b/drivers/staging/rts_pstor/trace.h >> @@ -39,7 +39,7 @@ static inline char *filename(char *path) >> while (*ptr != '\0') { >> if ((*ptr == '\\') || (*ptr == '/')) >> path = ptr + 1; >> - >> + >> ptr++; >> } > > For me it seems total filename() function could be squeezed to just > strrchr(path, '/') + 1; > Moreover there is already basename() in the lib/dynamic_debug.c you > could rename, export and reuse.
I will destroy this patch series. thanks. YAMANE Toshiaki _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
