On 2013-03-26 22:41, H Hartley Sweeten wrote:
The previous series for this driver had some issues pointed out by
Dan Carpenter and Ian Abbott. This series fixes/addresses those
issues.

v2: fix a bug in patch 5/12 that was pointed out by Ian Abbott.

H Hartley Sweeten (12):
   staging: comedi: s626: remove MC_TEST macro
   staging: comedi: s626: remove WR7146 and SETVECT macros
   staging: comedi: s626: remove RR7146 macro
   staging: comedi: s626: rename private data 'base_addr' variable
   staging: comedi: s626: remove the uint16_t casts of the bit values
   staging: comedi: s626: cleanup s626_dio_insn_config()
   staging: comedi: s626: cleanup s626_dio_insn_bits()
   staging: comedi: s626: remove subdevice pointer math
   staging: comedi: s626: cleanup subdevice init
   staging: comedi: s626: remove the ai (*insn_config) function
   staging: comedi: s626: async commands require an interrupt
   staging: comedi: s626: remove the "interrupt call test"

  drivers/staging/comedi/drivers/s626.c | 556 ++++++++++++++++------------------
  drivers/staging/comedi/drivers/s626.h |  60 ++--
  2 files changed, 295 insertions(+), 321 deletions(-)


They all looks fine to me.

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to