On 2013-04-08 22:29, H Hartley Sweeten wrote:
The printk's during the board attach are just added noise. Remove
them.
Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/staging/comedi/drivers/acl7225b.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/acl7225b.c
b/drivers/staging/comedi/drivers/acl7225b.c
index eb8e906..284232f 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -74,13 +74,8 @@ static int acl7225b_attach(struct comedi_device *dev,
iobase = it->options[0];
iorange = board->io_range;
- printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
- board->name, iobase);
- if (!request_region(iobase, iorange, "acl7225b")) {
- printk(KERN_ERR "comedi%d: request_region failed - I/O port
conflict\n",
- dev->minor);
+ if (!request_region(iobase, iorange, "acl7225b"))
return -EIO;
- }
Those errors messages are useful. Usually the first thing you do when
you run the "comedi_config" program to attach some legacy device and it
doesn't work is to run "dmesg" to find out what went wrong. At least
that's what we tell people to do on the comedi list!
dev->board_name = board->name;
dev->iobase = iobase;
dev->irq = 0;
--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
