This legacy driver does no additional probing so the dev->board_name
will already be properly initialized by the comedi core before calling
the (*attach) function.

Remove the unnecessary initialization of dev->board_name and use it
when requesting the resources instead of the open-coded strings.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/comedi/drivers/pcl730.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl730.c 
b/drivers/staging/comedi/drivers/pcl730.c
index e3de499..371f76c 100644
--- a/drivers/staging/comedi/drivers/pcl730.c
+++ b/drivers/staging/comedi/drivers/pcl730.c
@@ -72,11 +72,10 @@ static int pcl730_attach(struct comedi_device *dev, struct 
comedi_devconfig *it)
        iorange = board->io_range;
        printk(KERN_INFO "comedi%d: pcl730: board=%s 0x%04lx ", dev->minor,
               board->name, iobase);
-       if (!request_region(iobase, iorange, "pcl730")) {
+       if (!request_region(iobase, iorange, dev->board_name)) {
                printk("I/O port conflict\n");
                return -EIO;
        }
-       dev->board_name = board->name;
        dev->iobase = iobase;
        dev->irq = 0;
 
-- 
1.8.1.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to