Use __comedi_request_region() to request the I/O regions used by
this driver.

Remove the  error message when the request_region() fails,
comedi_request_reqion() will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/comedi/drivers/8255.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/8255.c 
b/drivers/staging/comedi/drivers/8255.c
index 0237187..4b91250 100644
--- a/drivers/staging/comedi/drivers/8255.c
+++ b/drivers/staging/comedi/drivers/8255.c
@@ -372,16 +372,13 @@ static int dev_8255_attach(struct comedi_device *dev,
                s = &dev->subdevices[i];
                iobase = it->options[i];
 
-               if (!request_region(iobase, _8255_SIZE, "8255")) {
-                       dev_warn(dev->class_dev,
-                               "0x%04lx (I/O port conflict)\n", iobase);
-
+               ret = __comedi_request_region(dev, iobase, _8255_SIZE);
+               if (ret) {
                        s->type = COMEDI_SUBD_UNUSED;
                } else {
                        ret = subdev_8255_init(dev, s, NULL, iobase);
                        if (ret)
                                return ret;
-                       dev_info(dev->class_dev, "0x%04lx\n", iobase);
                }
        }
 
-- 
1.8.1.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to