On Thu, May 23, 2013 at 06:38:17AM +0300, Xenia Ragiadakou wrote: > This patch fixes the following checkpatch warning: > WARNING: printk() should include KERN_ facility level > by replacing calls to printk with their corresponding calls > to pr_ (fmt, ...), defined in include/linux/printk.h, > and netdev_ (dev, fmt, ...) defined in include/linux/netdevice.h. > > Signed-off-by: Xenia Ragiadakou <[email protected]> > --- > > Differences from version 1: > some pr_ functions were replaced with more appropriate netdev_ functions.
This is much better than your first one. I still would prefer that you don't use pr_devel(). Everything inside pr_devel() is dead code. That means it gets compiled out away and it's not present in the final binary. It's possible that someone could turn it on but in reality no one is going to. pr_dbg() is the way to keep it around if it seems useful. Please delete the two unused functions and the dead #ifdeffed code I mentioned before. Greg is more generous than I am so he took the other patches. ;) regards, dan carpenter _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
