On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote:
> From: Niu Yawei <[email protected]>
> 
> In some cases such as kernel writeback, we shouldn't ignore the
> layout, otherwise, it could race with layout change undergoing.
> 
> Intel-bug-id: LU-3160

What can I do with this number?

> Lustre-commit: 3141db609d95d379761e3b54899618b4037d38f6

Or this one?

> Lustre-change: http://review.whamcloud.com/6154

This one is at least informative, so it can stay, if you really want it
there, but the others are not relevant to anyone outside of your
internal development environment, so do not belong in a Linux kernel
commit message, sorry.


> Signed-off-by: Niu Yawei <[email protected]>
> Signed-off-by: Jinshan Xiong <[email protected]>
> Reviewed-by: Andreas Dilger <[email protected]>
> Reviewed-by: Fan Yong <[email protected]>
> Reviewed-by: Oleg Drokin <[email protected]>
> 
> [updated for upstream kernel submission]

What's with the line break and this [] comment?  We don't care about
that.

> Signed-off-by: Peng Tao <[email protected]>
> Signed-off-by: Andreas Dilger <[email protected]>

It should be a unbroken series of lines here.

Care to fix this all up and resend?

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to