Hi, Tao
Thank you for the update.
I will look at the patchset later, currently I'm working on other issues.
Thanks.
Lianbo
On Fri, May 31, 2024 at 5:20 PM Tao Liu <l...@redhat.com> wrote:
> From: Aditya Gupta <adit...@linux.ibm.com>
>
> Currently, 'frame' is prohibited on every architecture, even in gdb mode.
> But with gdb stack unwinding working correctly on some architectures (eg.
> ppc64,
> x86_64, arm64), so remove it from prohibited list, so that 'frame' command
> can be used
>
> This has an implication on all architectures, that 'frame' now outputs
> this in default mode:
>
> ```
> crash> frame
> #0 <unavailable> in ?? ()
> ```
>
> instead of the before prohibited message
>
> ```
> crash> frame
> crash: prohibited gdb command: frame
> ```
>
> Though, 'frame' should work in gdb mode for architectures that implement
> 'machdep->get_cpu_reg'
>
> Cc: Sourabh Jain <sourabhj...@linux.ibm.com>
> Cc: Hari Bathini <hbath...@linux.ibm.com>
> Cc: Mahesh J Salgaonkar <mah...@linux.ibm.com>
> Cc: Naveen N. Rao <naveen.n....@linux.vnet.ibm.com>
> Cc: Lianbo Jiang <liji...@redhat.com>
> Cc: HAGIO KAZUHITO(萩尾 一仁) <k-hagio...@nec.com>
> Cc: Tao Liu <l...@redhat.com>
> Cc: Alexey Makhalov <alexey.makha...@broadcom.com>
> Signed-off-by: Aditya Gupta <adit...@linux.ibm.com>
> ---
> gdb_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb_interface.c b/gdb_interface.c
> index b14319c..8f99a0d 100644
> --- a/gdb_interface.c
> +++ b/gdb_interface.c
> @@ -711,7 +711,7 @@ static char *prohibited_list[] = {
> "watch", "rwatch", "awatch", "attach", "continue", "c", "fg",
> "detach",
> "finish", "handle", "interrupt", "jump", "kill", "next", "nexti",
> "signal", "step", "s", "stepi", "target", "until", "delete",
> - "clear", "disable", "enable", "condition", "ignore", "frame",
> "catch",
> + "clear", "disable", "enable", "condition", "ignore", "catch",
> "tcatch", "return", "file", "exec-file", "core-file",
> "symbol-file",
> "load", "si", "ni", "shell", "sy",
> NULL /* must be last */
> --
> 2.40.1
>
>
--
Crash-utility mailing list -- devel@lists.crash-utility.osci.io
To unsubscribe send an email to devel-le...@lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
