Hi Lianbo,
On 25/07/23 09:53AM, lijiang wrote:
> Hi, Aditya
> Thank you for the patch.
> On Wed, Jun 18, 2025 at 1:33 PM Aditya Gupta <adit...@linux.ibm.com> wrote:
>
> > <...snip...>
> >
> > +/**
> > + * Check if vmcoreinfo in vmcore is missing/empty
> > + */
> > +static bool is_vmcoreinfo_empty(void)
> > +{
> > + return (dd->sub_header_kdump->size_vmcoreinfo == 0);
> > +}
> >
> >
> I have seen two versions of the implementation, another one is in
> netdump.c. Can we do it like this?
>
> bool is_vmcoreinfo_empty(void)
> {
> if (dd && dd->sub_header_kdump)
> return (dd->sub_header_kdump->size_vmcoreinfo == 0);
> if (nd)
> return (nd->size_vmcoreinfo == 0);
> return true;
> }
>
> And implement it in a common file, E.g: kernel.c, put its definition to
> defs.h. So that we can call this one in netdump.c and diskdump.c.
> What do you think?
Sure, makes sense. Will do it.
>
> Other changes are fine to me.
>
Thanks,
- Aditya G
> Thanks
> Lianbo
>
>
--
Crash-utility mailing list -- devel@lists.crash-utility.osci.io
To unsubscribe send an email to devel-le...@lists.crash-utility.osci.io
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
